-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Implement clamp_to #150075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kyuuhachi
wants to merge
1
commit into
rust-lang:main
Choose a base branch
from
Kyuuhachi:limit_to
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+262
−0
Open
Implement clamp_to #150075
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| use crate::marker::Destruct; | ||
| use crate::ops::{RangeFrom, RangeFull, RangeInclusive, RangeToInclusive}; | ||
|
|
||
| /// Trait for ranges supported by [`Ord::clamp_to`]. | ||
| #[unstable(feature = "clamp_bounds", issue = "147781")] | ||
| #[rustc_const_unstable(feature = "clamp_bounds", issue = "147781")] | ||
| pub const trait ClampBounds<T>: Sized { | ||
| /// The implementation of [`Ord::clamp_to`]. | ||
| fn clamp(self, value: T) -> T | ||
| where | ||
| T: [const] Destruct; | ||
| } | ||
|
|
||
| #[unstable(feature = "clamp_bounds", issue = "147781")] | ||
| #[rustc_const_unstable(feature = "clamp_bounds", issue = "147781")] | ||
| impl<T> const ClampBounds<T> for RangeFrom<T> | ||
| where | ||
| T: [const] Ord, | ||
| { | ||
| fn clamp(self, value: T) -> T | ||
| where | ||
| T: [const] Destruct, | ||
| { | ||
| value.max(self.start) | ||
| } | ||
| } | ||
|
|
||
| #[unstable(feature = "clamp_bounds", issue = "147781")] | ||
| #[rustc_const_unstable(feature = "clamp_bounds", issue = "147781")] | ||
| impl<T> const ClampBounds<T> for RangeToInclusive<T> | ||
| where | ||
| T: [const] Ord, | ||
| { | ||
| fn clamp(self, value: T) -> T | ||
| where | ||
| T: [const] Destruct, | ||
| { | ||
| value.min(self.end) | ||
| } | ||
| } | ||
|
|
||
| #[unstable(feature = "clamp_bounds", issue = "147781")] | ||
| #[rustc_const_unstable(feature = "clamp_bounds", issue = "147781")] | ||
| impl<T> const ClampBounds<T> for RangeInclusive<T> | ||
| where | ||
| T: [const] Ord, | ||
| { | ||
| fn clamp(self, value: T) -> T | ||
| where | ||
| T: [const] Destruct, | ||
| { | ||
| let (start, end) = self.into_inner(); | ||
| value.clamp(start, end) | ||
| } | ||
| } | ||
|
|
||
| #[unstable(feature = "clamp_bounds", issue = "147781")] | ||
| #[rustc_const_unstable(feature = "clamp_bounds", issue = "147781")] | ||
| impl<T> const ClampBounds<T> for RangeFull { | ||
| fn clamp(self, value: T) -> T { | ||
| value | ||
| } | ||
| } | ||
|
|
||
| macro impl_for_float($t:ty) { | ||
| #[unstable(feature = "clamp_bounds", issue = "147781")] | ||
| #[rustc_const_unstable(feature = "clamp_bounds", issue = "147781")] | ||
| impl const ClampBounds<$t> for RangeFrom<$t> { | ||
| fn clamp(self, value: $t) -> $t { | ||
| value.max(self.start) | ||
| } | ||
| } | ||
|
|
||
| #[unstable(feature = "clamp_bounds", issue = "147781")] | ||
| #[rustc_const_unstable(feature = "clamp_bounds", issue = "147781")] | ||
| impl const ClampBounds<$t> for RangeToInclusive<$t> { | ||
| fn clamp(self, value: $t) -> $t { | ||
| value.min(self.end) | ||
| } | ||
| } | ||
|
|
||
| #[unstable(feature = "clamp_bounds", issue = "147781")] | ||
| #[rustc_const_unstable(feature = "clamp_bounds", issue = "147781")] | ||
| impl const ClampBounds<$t> for RangeInclusive<$t> { | ||
| fn clamp(self, value: $t) -> $t { | ||
| let (start, end) = self.into_inner(); | ||
| // Deliberately avoid using `clamp` to handle NaN consistently | ||
| value.max(start).min(end) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // #[unstable(feature = "f16", issue = "116909")] | ||
| impl_for_float!(f16); | ||
| impl_for_float!(f32); | ||
| impl_for_float!(f64); | ||
| // #[unstable(feature = "f128", issue = "116909")] | ||
| impl_for_float!(f128); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be very surprised if
x.clamp_to(a..=b)were to behave differently at all fromx.clamp(a, b), regardless of the various values forx,a, andb.Isn't
clampmoving toward making its NaN behaviour consistent, anyway?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but imo it's worse if
x.clamp_to(a..)andx.clamp_to(a..=b)handle nan differently. Making all of them panic on nan would be a plausible choice though. It's listed as an unresolved question on the tracking issue.