-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Make asm_experimental_arch work in allow_internal_unstable macros
#150073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Make asm_experimental_arch work in allow_internal_unstable macros
#150073
Conversation
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions.
- What's the motivation for this? Did it come up in a particular real-world context?
- Presumably targets with stable
asm!/global_asm!are unaffected by this? - The PR description mentions proc macros, but the test uses a declarative macro. Why is this?
I'm also wondering if this will need some kind of libs/lang approval.
Yes, we are planning to use this in Currently we encode a bunch of information in really strange ways into the Wasm module and we are planning to make the next version of
Yes, this only affects targets requiring
The mechanism is the same, I've double-checked by trying it out locally. Happy to add a dedicated proc-macro test! |
|
No need to add a proc macro test. I'll just check on Zulip if we need any kind of libs/lang sign-off, otherwise this looks ok to me. |
This change makes it possible to use unstable
asm!, usually requiringfeature(asm_experimental_arch), in proc-macros with theallow_internal_unstableattribute.The test was added on a target where
asm!is unstable: Wasm. However, this affects any target with an unstableasm!implementation.