Enable file locking support for Hurd #150058
Draft
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like Illumos (rust-lang#148322) and aix (rust-lang#148619), Hurd was missed when originally introducing locking gates per target OS in rust-lang#132977. building rustc on Hurd was broken as a result since 1.91. Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
rustbot
added
S-waiting-on-author
Contributor
Author
|
(marked as draft for now because my test build of 1.91.1 with this backported is still running, and I want to ensure it works as expected end-to-end before it gets merged!) |
Member
|
Thanks for the fix. This obviously seems fine if it fixes the issue, which you will know better, so, r=me after you verify. r? @workingjubilee |
Collaborator
|
✌️ @Fabian-Gruenbichler, you can now approve this pull request! If @workingjubilee told you to " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like Illumos (#148322) and aix (#148619), Hurd was missed when originally introducing locking gates per target OS in #132977. building rustc on Hurd was broken as a result since 1.91.