Fix test_no_memory_leak failure #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
force-pushed
the
fix_memory_leak_test
branch
2 times, most recently
from
42e8b4f to
0a104d4
Compare
Avoid memory leak when TypedData_Wrap_Struct fail. First, prepare TypedData_Wrap_Struct with NULL. Next, allocate Real. Finally, bind VALUE and Real.
tompng
force-pushed
the
fix_memory_leak_test
branch
from
0a104d4 to
7ca76fa
Compare
nobu
added a commit
to nobu/ruby
that referenced
this pull request
Oct 1, 2025
Incorporate ruby/bigdecimal#424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid memory leak when TypedData_Wrap_Struct fail.
This was already done in f141928, partially broken in some commit, and accidentally dropped in #410
TODO
test_no_memory_leak_BigDecimaltest_no_memory_leak_createtest in CI.