Change BigMath.sin and cos to always calculate in relative precision. #422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all methods in BigDecimal/BigMath that takes precision calculates in relative precision.
Only
BigMath.sin(except x around 0) andBigMath.cos(always) was calculating in fixed-point precision.There is no document that says sin and cos is fixed-point precision. It can be considered bug (or wrong document).
Other
xaroundint * π / 2, so if sin and cos is in fixed-point precision, it's not consistent.