Hint the origin of the theme #84
Open
+39
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahiDroid
changed the title
RahiDroid
reviewed
Dec 29, 2022
divyarajmasani
requested changes
Jan 16, 2025
| const replaceFileContent = (files, chunksToReplace, newChunk) => { | ||
| files.forEach((file) => { | ||
|
|
||
| if(path.basename(file) === 'init.js' && (chunksToReplace === 'Blank theme' || chunksToReplace === 'underscore theme' || chunksToReplace === 'blankTheme')) { |
Contributor
There was a problem hiding this comment.
If we are not supposed to make any replacement in init.js, other checks are not needed.
Suggested change
| if(path.basename(file) === 'init.js' && (chunksToReplace === 'Blank theme' || chunksToReplace === 'underscore theme' || chunksToReplace === 'blankTheme')) { | |
| if(path.basename(file) === 'init.js') { |
| @@ -1,4 +1,4 @@ | |||
| # Copyright (C) 2021 Blank Theme | |||
| # Copyright (C) 2022 Blank Theme | |||
Contributor
There was a problem hiding this comment.
Is this auto generated?
| Blank Theme is based on Underscores http://underscores.me/, (C) 2012-2015 Automattic, Inc. | ||
| Underscores is distributed under the terms of the GNU GPL v2 or later. | ||
| Blank Theme is based on Blank theme https://github.com/rtCamp/blankTheme |
Contributor
There was a problem hiding this comment.
Blank Theme is also distributed under the same license, want to retain the license string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
To-do
Fixes/Covers issue
Fixes #82