[CMake] Fix vetoes for tutorials if numpy or xrootd are not available #20659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 21 files 21 suites 3d 17h 23m 10s ⏱️ Results for commit 4fba06b. ♻️ This comment has been updated with latest results. |
vepadulano
requested changes
Dec 10, 2025
This doesn't help the user, and also confuses the CI when testing, because tutorials can apparently succeed even if they do nothing.
Follows up on 45bef34, adding a veto if NumPy is not found. Also, move vetoes for tutorials when xrootd is not available to the right place.
guitargeek
force-pushed
the
tutorials_veto
branch
from
aedec41 to
4fba06b
Compare
vepadulano
approved these changes
Dec 10, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
LGTM thanks! Please merge once CI is green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on 45bef34, adding a veto if NumPy is not found. Also, move vetoes for tutorials when xrootd is not available to the right place.