Skip to content

Conversation

Copy link

Copilot AI commented Jan 14, 2026

Python 3.13 Support Implementation Plan

  • Understand the issue: pillow dependency from prometheus-api-client doesn't support Python 3.13
  • Identify the solution: Use prometheus-api-client-optional-matplotlib instead
  • Update pyproject.toml to:
    • Change python version constraint to support up to Python 3.13
    • Replace prometheus-api-client with prometheus-api-client-optional-matplotlib
    • Update other dependency versions as needed
  • Update poetry.lock file with new dependencies
  • Test that the changes work (build and basic functionality)
  • Run code review
  • Run security scan with codeql_checker
  • Finalize changes
Original prompt

This section details on the original issue you should resolve

<issue_title>KRR doesn't support newer python version (i.e. python3.13)</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)

@aantn This *should* be a trivial change to pyproject.toml to set the python requirement to `python<4.0` or `python<3.14` but because we have a dependency for pillow, this causes all sorts of problems. e.g:
$ poetry install
Installing dependencies from lock file

Package operations: 76 installs, 0 updates, 0 removals

  - Installing six (1.16.0)
  - Installing certifi (2024.2.2)
  - Installing jmespath (1.0.1)
  - Installing idna (3.7)
  - Installing charset-normalizer (3.3.2)
  - Installing numpy (1.26.4)
  - Installing python-dateutil (2.9.0.post0)
  - Installing urllib3 (1.26.20)
  - Installing fonttools (4.49.0)
  - Installing cycler (0.12.1)
  - Installing contourpy (1.2.0): Preparing...
  - Installing packaging (24.0)
  - Installing kiwisolver (1.4.5): Preparing...
  - Installing pyasn1 (0.5.1)
  - Installing pyparsing (3.1.2)
  - Installing botocore (1.34.62)
  - Installing pytz (2024.1)
  - Installing pillow (10.3.0): Failed

PEP517 build of a dependency failed

Backend subprocess exited when trying to invoke get_requires_for_build_wheel

    | Command '['/var/folders/9d/w12tylk1403bjxd6k93pdqp80000gn/T/tmp1lpogca6/.venv/bin/python', '/Users/natanyellin/Library/Application Support/pypoetry/venv/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py', 'get_requires_for_build_wheel', '/var/folders/9d/w12tylk1403bjxd6k93pdqp80000gn/T/tmp2st31ymu']' returned non-zero exit status 1.
    |
    | Traceback (most recent call last):
    |   File "/Users/natanyellin/Library/Application Support/pypoetry/venv/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
    |     main()
    |     ~~~~^^
    |   File "/Users/natanyellin/Library/Application Support/pypoetry/venv/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 373, in main
  - Installing pyasn1 (0.5.1)
  - Installing pyparsing (3.1.2)
  - Installing botocore (1.34.62)
  - Installing pytz (2024.1)
  - Installing pillow (10.3.0): Failed

PEP517 build of a dependency failed

Backend subprocess exited when trying to invoke get_requires_for_build_wheel

    | Command '['/var/folders/9d/w12tylk1403bjxd6k93pdqp80000gn/T/tmp1lpogca6/.venv/bin/python', '/Users/natanyellin/Library/Application Support/pypoetry/venv/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py', 'get_requires_for_build_wheel', '/var/folders/9d/w12tylk1403bjxd6k93pdqp80000gn/T/tmp2st31ymu']' returned non-zero exit status 1.
    |
    | Traceback (most recent call last):
    |   File "/Users/natanyellin/Library/Application Support/pypoetry/venv/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
    |     main()
    |     ~~~~^^
    |   File "/Users/natanyellin/Library/Application Support/pypoetry/venv/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 373, in main
  - Installing kiwisolver (1.4.5): Installing...
  - Installing pyasn1 (0.5.1)
  - Installing pyparsing (3.1.2)
  - Installing botocore (1.34.62)
  - Installing pytz (2024.1)
  - Installing pillow (10.3.0): Failed

PEP517 build of a dependency failed

Backend subprocess exited when trying to invoke get_requires_for_build_wheel

    | Command '['/var/folders/9d/w12tylk1403bjxd6k93pdqp80000gn/T/tmp1lpogca6/.venv/bin/python', '/Users/natanyellin/Library/Application Support/pypoetry/venv/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py', 'get_requires_for_build_wheel', '/var/folders/9d/w12tylk1403bjxd6k93pdqp80000gn/T/tmp2st31ymu']' returned non-zero exit status 1.
    |
    | Traceback (most recent call last):
    |   File "/Users/natanyellin/Library/Application Support/pypoetry/venv/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
    |     main()
    |     ~~~~^^
    |   File "/Users/natanyellin/Library/Application Support/pypoetry/venv/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 373, in main
  - Installing pyasn1 (0.5.1)
  - Installing pyparsing (3.1.2)
  - Installing botocore (1.34.62)
  - Installing pytz (2024.1)
  - Installing pillow (10.3.0): Failed

PEP517 build of a dependency failed

Backend subprocess exited when trying to invoke get_requires_for_build_wheel

    | Command '['/var/folders/9d/w12tylk1403bjxd6k93pdqp80000gn/T/tmp1lpogca6/.venv/bin/python', '/Users/natanyellin/Library/Application Support/pypoetry/venv/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py', 'get_requires_for_build_wheel', '/var/folders/9d/w12tylk1403bjxd6k93pdqp80000gn/T/tmp2st31ymu']' returned non-zero exit status 1.
    |
    | Traceback...

</details>



<!-- START COPILOT CODING AGENT SUFFIX -->

- Fixes robusta-dev/krr#435

<!-- START COPILOT CODING AGENT TIPS -->
---

✨ Let Copilot coding agent [set things up for you](https://github.com/robusta-dev/krr/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@arikalon1 arikalon1 closed this Jan 14, 2026
Copilot stopped work on behalf of arikalon1 due to an error January 14, 2026 21:20
Copilot AI requested a review from arikalon1 January 14, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants