-
Notifications
You must be signed in to change notification settings - Fork 258
[ROB-2920] CVE patches enforcer #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates the enforcer component by removing explicit sqlite version pins in the Dockerfile to rely on distro-provided versions instead, adds urllib3==2.6.2 to Python dependencies, and bumps the helm chart image tag from 0.3.5 to 0.3.6. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
enforcer/Dockerfileenforcer/requirements.txthelm/krr-enforcer/values.yaml
🔇 Additional comments (2)
helm/krr-enforcer/values.yaml (1)
14-14: LGTM!The image tag bump from 0.3.5 to 0.3.6 correctly aligns with the updated container image that includes the CVE patches.
enforcer/requirements.txt (1)
9-9: Remove this comment — no issues to address.urllib3==2.6.2 fully addresses both CVE-2025-66418 and CVE-2025-66471 (both fixed in 2.6.0). Kubernetes 26.1.0 specifies
urllib3 (>=1.24.2), a lower-bound requirement only, so pinning to 2.6.2 creates no version conflicts and is compatible.Likely an incorrect or invalid review comment.
CVE-2025-66418
CVE-2025-66471
tested it works