Skip to content

Conversation

@maliesa96
Copy link
Contributor

@maliesa96 maliesa96 commented Oct 22, 2020

Note this builds on top of the dueling and double PRs so the diff will be redundant. Also will add tests shortly.

@maliesa96 maliesa96 requested a review from a team as a code owner October 22, 2020 22:25
@maliesa96 maliesa96 requested review from ahtsan and removed request for a team October 22, 2020 22:25
@mergify mergify bot requested review from a team, gitanshu and nicolengsy and removed request for a team October 22, 2020 22:26
This also adds several smaller features:
 - torch/examples/watch_atari.py: use a trained agent to play atari.
 - Error handling in the snapshotter for invalid arguments.
 - torch/examples/dqn_atari.py: train on atari environments.
This also adds several smaller features:
 - torch/examples/watch_atari.py: use a trained agent to play atari.
 - Error handling in the snapshotter for invalid arguments.
 - torch/examples/dqn_atari.py: train on atari environments.
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #2152 (f40ee60) into master (e32cd06) will decrease coverage by 23.47%.
The diff coverage is 19.35%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2152       +/-   ##
===========================================
- Coverage   91.48%   68.00%   -23.48%     
===========================================
  Files         195      198        +3     
  Lines       10675    11037      +362     
  Branches     1340     1403       +63     
===========================================
- Hits         9766     7506     -2260     
- Misses        657     3147     +2490     
- Partials      252      384      +132     
Impacted Files Coverage Δ
...rc/garage/torch/modules/multi_headed_mlp_module.py 83.67% <ø> (-16.33%) ⬇️
...arage/torch/q_functions/discrete_cnn_q_function.py 42.85% <ø> (-50.00%) ⬇️
src/garage/torch/modules/discrete_cnn_module.py 16.00% <7.89%> (-84.00%) ⬇️
src/garage/torch/modules/noisy_mlp_module.py 22.36% <22.36%> (ø)
src/garage/torch/algos/dqn.py 86.36% <40.00%> (-6.44%) ⬇️
src/garage/tf/algos/te.py 12.50% <0.00%> (-87.50%) ⬇️
src/garage/tf/algos/te_npo.py 9.25% <0.00%> (-85.00%) ⬇️
src/garage/torch/modules/categorical_cnn_module.py 17.94% <0.00%> (-82.06%) ⬇️
src/garage/sampler/ray_sampler.py 18.34% <0.00%> (-81.66%) ⬇️
.../tf/policies/gaussian_mlp_task_embedding_policy.py 19.67% <0.00%> (-80.33%) ⬇️
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e32cd06...f40ee60. Read the comment docs.

@maliesa96 maliesa96 force-pushed the noisy_dqn branch 2 times, most recently from 3a3770f to 2ec217c Compare October 30, 2020 00:08
@gitanshu gitanshu requested review from krzentner and removed request for gitanshu November 7, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants