-
Notifications
You must be signed in to change notification settings - Fork 899
feat: react email skill improvements #2895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 7 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="skills/react-email/SKILL.md">
<violation number="1" location="skills/react-email/SKILL.md:408">
P2: SKILL.md exceeds the documented <350 line limit for core skill instructions, which breaks the progressive disclosure constraints. Consider moving detailed sections to references and trimming the core file below 350 lines.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="skills/react-email/SKILL.md">
<violation number="1" location="skills/react-email/SKILL.md:273">
P2: The Tailwind config example imports only Tailwind and Img but uses Body, Container, and Button, so the snippet is not runnable. Include the missing components in the import to keep the example correct.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
e80aa38 to
9a329a2
Compare
Summary by cubic
Reorganized the React Email skill under skills/react-email and expanded the docs for clearer setup, Tailwind usage, rendering, and sending. Added guidance for existing projects, assets, and common pitfalls.
Refactors
New Features
Written for commit e21776f. Summary will update on new commits.