-
Notifications
You must be signed in to change notification settings - Fork 899
fix(web): add discernible text to landing page links #2882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
|
|
@yanthomasdev is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
|
We're actually going to change that workflow of merging to main directly, mainly because want to avoid bringing in changes from |
This PR adds discernible text to the landing page links. Currently, assistive technologies don't have any textual cue of what the images mean, so an
sr-onlyspan was added with "home", for the home page link in the React Email logo, and the name of the service for the integration section links. This is a necessary change to comply with WCAG's Sucess Criterion 1.4.2 - Name, Role Value (Level A).Fun fact, some assistive technologies (like NVDA) workaround this missing information using the link's
hrefand the page'stitlemetadata, so they actually read these links fine in my main screen reader, but it's always nice to go with the most compatible approach to ensure wider compatibility and reap the SEO and AI benefits as well.I am making this PR against
mainbased on the contributing guide's instructions, since my last PR was merged intocanaryI believe it did not trigger a new deploy for the app.Summary by cubic
Add sr-only labels to the home logo link and each integration link so screen readers announce meaningful labels. Improves accessibility and aligns with WCAG’s Name, Role, Value.
Written for commit 9a152c3. Summary will update on new commits.