You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist
Code in this PR is covered by automated tests (Unit tests, E2E tests)
My changes generate no new warnings
I have reviewed my own code
I have filled out all required sections
I have tested my changes on the preview link
Approver of this PR confirms that the changes are tested on the preview link
Note
Hook & API updates
Extends useAppKitWallets with wcError, deep-link failure detection (visibility/focus/timeout), and new onError callback delivering WalletConnectionError (type, message, wallet, originalError).
Clears state on (re)connect attempts (wcError, wcLinking, internal refs) and avoids reusing handled wcUri unless linking is cleared.
Controllers
ConnectionController: adds wcError state with setWcError, resets wcLinking/wcError in resetUri, tracks deep-link start (wcLinking) and timeout handling.
Error utilities & types (common)
Adds ConnectionErrorType and CONNECTION_ERROR_TYPE constants, getErrorMessage() helper, and exports ProviderRpcErrorCode/ConnectionErrorType.
Example UI (Next app)
ConnectCard.tsx: integrates useAppKitWallets({ onError }), shows mobile deep-link failure banner with dismiss, suppresses duplicate toasts, hides QR on mobile.
Config
tsconfig.json in example: switch JSX to preserve.
Written by Cursor Bugbot for commit 803a4fa. This will update automatically on new commits. Configure here.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
[baseline-browser-mapping] The data in this module is over two months old. To ensure accurate Baseline data, please update: npm i baseline-browser-mapping@latest -D
@reown/appkit - Main Entry
Size limit: 80 kB
Size: 75.07 kB with all dependencies, minified and gzipped
Loading time: 1.5 s on slow 3G
Running time: 375 ms on Snapdragon 410
Total time: 1.9 s
@reown/appkit/react
Size limit: 235 kB
Size: 233.1 kB with all dependencies, minified and gzipped
Loading time: 4.6 s on slow 3G
Running time: 1.2 s on Snapdragon 410
Total time: 5.8 s
@reown/appkit/vue
Size limit: 80 kB
Size: 75.07 kB with all dependencies, minified and gzipped
Loading time: 1.5 s on slow 3G
Running time: 521 ms on Snapdragon 410
Total time: 2 s
@reown/appkit-scaffold-ui
Size limit: 220 kB
Size: 212.57 kB with all dependencies, minified and gzipped
Loading time: 4.2 s on slow 3G
Running time: 617 ms on Snapdragon 410
Total time: 4.8 s
@reown/appkit-ui
Size limit: 500 kB
Size: 13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms on slow 3G
Running time: 126 ms on Snapdragon 410
Total time: 383 ms
The reason will be displayed to describe this comment to others. Learn more.
Cleanup effect immediately clears newly-set error state
The cleanup effect at lines 456-458 clears wcError whenever connectingWallet?.id changes. When the error detection logic sets connectingWallet to undefined and wcError to true, this triggers the cleanup effect on the next render cycle. The effect checks if (ConnectionController.state.wcError) and immediately sets it back to false. Even if the display condition bug were fixed, this cleanup logic would still clear the error before the user could see it. The cleanup intent is for wallet switching, but it incorrectly also triggers when the wallet is cleared due to an error.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Description
Testing another approach. might close #5430
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist
Note
Hook & API updates
useAppKitWalletswithwcError, deep-link failure detection (visibility/focus/timeout), and newonErrorcallback deliveringWalletConnectionError(type,message,wallet,originalError).wcError,wcLinking, internal refs) and avoids reusing handledwcUriunless linking is cleared.Controllers
ConnectionController: addswcErrorstate withsetWcError, resetswcLinking/wcErrorinresetUri, tracks deep-link start (wcLinking) and timeout handling.Error utilities & types (common)
ConnectionErrorTypeandCONNECTION_ERROR_TYPEconstants,getErrorMessage()helper, and exportsProviderRpcErrorCode/ConnectionErrorType.Example UI (Next app)
ConnectCard.tsx: integratesuseAppKitWallets({ onError }), shows mobile deep-link failure banner with dismiss, suppresses duplicate toasts, hides QR on mobile.Config
tsconfig.jsonin example: switch JSX topreserve.Written by Cursor Bugbot for commit 803a4fa. This will update automatically on new commits. Configure here.