-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Missing enabled coinbase transfer from init to state #5403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
@Strnadj is attempting to deploy a commit to the Reown Team on Vercel. A member of the Team first needs to authorize it. |
|
All contributors have signed the CTA ✍️ ✅ |
|
I have read the CTA Document and I hereby sign the CTA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to fix a bug where the enableCoinbase option was not being populated from AppKit to OptionsController during initialization. The change adds a single line to set the Coinbase enabled state in the options initialization flow.
Key Changes:
- Added
OptionsController.setEnabledCoinbase(options.enableCoinbase === true)to theinitializeOptionsControllermethod to populate the missingenableCoinbaseoption
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description
offers a various option, I figure out (the hard way) that if you want to really disable Coinbase, you have to set this value directly in the controller like this:
Which is kind of confusing and I think not expected.
Type of change
Associated Issues
Not sure if there is an issue... I am sending a fix.
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist