Skip to content

Conversation

@Strnadj
Copy link

@Strnadj Strnadj commented Dec 10, 2025

Description

createAppKit({ .... })

offers a various option, I figure out (the hard way) that if you want to really disable Coinbase, you have to set this value directly in the controller like this:

  import { OptionsController } from "@reown/appkit-controllers";
  OptionsController.state.enableCoinbase = false;

Which is kind of confusing and I think not expected.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

Not sure if there is an issue... I am sending a fix.

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copilot AI review requested due to automatic review settings December 10, 2025 11:38
@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2025

⚠️ No Changeset found

Latest commit: 115b633

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 10, 2025

@Strnadj is attempting to deploy a commit to the Reown Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

All contributors have signed the CTA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Strnadj
Copy link
Author

Strnadj commented Dec 10, 2025

I have read the CTA Document and I hereby sign the CTA

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix a bug where the enableCoinbase option was not being populated from AppKit to OptionsController during initialization. The change adds a single line to set the Coinbase enabled state in the options initialization flow.

Key Changes:

  • Added OptionsController.setEnabledCoinbase(options.enableCoinbase === true) to the initializeOptionsController method to populate the missing enableCoinbase option

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Strnadj Strnadj changed the title Missing enabled coinbase Missing enabled coinbase transfer from init to state Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant