-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix: show customWallets in all wallets list when there are no adapters #5386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5c7737d The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
Visual Regression Test Results ✅ Passed✨ No visual changes detected Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=478 |
| name: 'Custom Wallet 2', | ||
| homepage: 'https://custom2.com', | ||
| image_url: 'https://custom2.com/icon.png' | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: External Domain URL Detected (Bugbot Rules)
This change introduces URLs pointing to external domains (https://custom1.com and https://custom2.com). Please verify that these external dependencies are intentional and review for potential security, privacy, or compliance implications. Approved company domains are: reown.com, walletconnect.com, walletconnect.org
Note: These appear to be mock/placeholder URLs used only in unit tests for testing the custom wallet functionality.
|
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit > size-limit |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Description
Fix: show customWallets in all wallets list when there are no adapters
Type of change
Associated Issues
For Linear issues: Closes APKT-3856
For GH issues: closes #5062
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist
Note
Includes
customWalletsin the all-wallets list by converting them toWcWalletwhennoAdaptersis true, with tests and patch bumps.packages/controllers/src/utils/WalletUtil.ts):getWalletConnectWalletsto includeOptionsController.state.customWalletswhenChainController.state.noAdaptersis true by converting them toWcWallet(supports_wc: true) and excluding duplicates.uniqueBy('id'), mark installed, filter by WC support, adddisplay_index.packages/scaffold-ui/test/WalletUtil.test.ts):noAdapters, not converting otherwise, handling empty custom list, de-duplication vs existing wallets, inclusion alongside featured/recommended, and preferringfilteredWallets.@reown/appkit-controllersand@reown/appkit-scaffold-ui.Written by Cursor Bugbot for commit 5c7737d. This will update automatically on new commits. Configure here.