Skip to content

Conversation

@svenvoskamp
Copy link
Contributor

@svenvoskamp svenvoskamp commented Dec 3, 2025

Description

Fix: show customWallets in all wallets list when there are no adapters

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-3856
For GH issues: closes #5062

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Note

Includes customWallets in the all-wallets list by converting them to WcWallet when noAdapters is true, with tests and patch bumps.

  • Controllers (packages/controllers/src/utils/WalletUtil.ts):
    • Update getWalletConnectWallets to include OptionsController.state.customWallets when ChainController.state.noAdapters is true by converting them to WcWallet (supports_wc: true) and excluding duplicates.
    • Preserve existing flow: merge featured/recommended/filtered/all wallets, uniqueBy('id'), mark installed, filter by WC support, add display_index.
  • Tests (packages/scaffold-ui/test/WalletUtil.test.ts):
    • Add cases for converting custom wallets on noAdapters, not converting otherwise, handling empty custom list, de-duplication vs existing wallets, inclusion alongside featured/recommended, and preferring filteredWallets.
  • Changesets:
    • Patch bumps for @reown/appkit-controllers and @reown/appkit-scaffold-ui.

Written by Cursor Bugbot for commit 5c7737d. This will update automatically on new commits. Configure here.

svenvoskamp added 30 commits May 6, 2025 09:33
@linear
Copy link

linear bot commented Dec 3, 2025

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2025

🦋 Changeset detected

Latest commit: 5c7737d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@reown/appkit-controllers Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-ton Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-ui Patch
@reown/appkit-core Patch
@reown/appkit-utils Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet-button Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-cdn Patch
@reown/appkit-universal-connector Patch
@reown/appkit-testing Patch
@reown/appkit-common Patch
@reown/appkit-polyfills Patch
@reown/appkit-wallet Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Dec 3, 2025 11:21am
appkit-demo Ready Ready Preview Comment Dec 3, 2025 11:21am
appkit-gallery Ready Ready Preview Comment Dec 3, 2025 11:21am
appkit-headless-sample-app Ready Ready Preview Comment Dec 3, 2025 11:21am
appkit-laboratory Ready Ready Preview Comment Dec 3, 2025 11:21am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Dec 3, 2025 11:21am
appkit-basic-sign-client-example Ignored Ignored Dec 3, 2025 11:21am
appkit-basic-up-example Ignored Ignored Dec 3, 2025 11:21am
appkit-ethers5-bera Ignored Ignored Dec 3, 2025 11:21am
appkit-nansen-demo Ignored Ignored Dec 3, 2025 11:21am
appkit-vue-solana Ignored Ignored Dec 3, 2025 11:21am
appkit-wagmi-cdn-example Ignored Ignored Dec 3, 2025 11:21am
ethereum-provider-wagmi-example Ignored Ignored Dec 3, 2025 11:21am
next-wagmi-solana-bitcoin-example Ignored Ignored Dec 3, 2025 11:21am
vue-wagmi-example Ignored Ignored Dec 3, 2025 11:21am

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Visual Regression Test Results ✅ Passed

✨ No visual changes detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=478
Storybook Preview: https://6493191bf4b10fed8ca7353f-rfvqdkdsth.chromatic.com/

name: 'Custom Wallet 2',
homepage: 'https://custom2.com',
image_url: 'https://custom2.com/icon.png'
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: External Domain URL Detected (Bugbot Rules)

This change introduces URLs pointing to external domains (https://custom1.com and https://custom2.com). Please verify that these external dependencies are intentional and review for potential security, privacy, or compliance implications. Approved company domains are: reown.com, walletconnect.com, walletconnect.org

Note: These appear to be mock/placeholder URLs used only in unit tests for testing the custom wallet functionality.

Fix in Cursor Fix in Web

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Warnings
⚠️

🌐 Non-company domain introduced (host: custom1.com) in packages/scaffold-ui/test/WalletUtil.test.ts (line 412): https://custom1.com

⚠️

🌐 Non-company domain introduced (host: custom1.com) in packages/scaffold-ui/test/WalletUtil.test.ts (line 413): https://custom1.com/icon.png

⚠️

🌐 Non-company domain introduced (host: custom1.com) in packages/scaffold-ui/test/WalletUtil.test.ts (line 414): https://custom1.com/mobile

⚠️

🌐 Non-company domain introduced (host: custom1.com) in packages/scaffold-ui/test/WalletUtil.test.ts (line 415): https://custom1.com/desktop

⚠️

🌐 Non-company domain introduced (host: custom2.com) in packages/scaffold-ui/test/WalletUtil.test.ts (line 421): https://custom2.com

⚠️

🌐 Non-company domain introduced (host: custom2.com) in packages/scaffold-ui/test/WalletUtil.test.ts (line 422): https://custom2.com/icon.png

Generated by 🚫 dangerJS against 5c7737d

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit


> size-limit

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         71.36 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 386 ms   on Snapdragon 410
Total time:   1.8 s
@reown/appkit/react
Size limit:   230 kB
Size:         228.36 kB with all dependencies, minified and gzipped
Loading time: 4.5 s     on slow 3G
Running time: 915 ms    on Snapdragon 410
Total time:   5.4 s
@reown/appkit/vue
Size limit:   80 kB
Size:         71.36 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 451 ms   on Snapdragon 410
Total time:   1.9 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         209.48 kB with all dependencies, minified and gzipped
Loading time: 4.1 s     on slow 3G
Running time: 568 ms    on Snapdragon 410
Total time:   4.7 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms   on slow 3G
Running time: 77 ms    on Snapdragon 410
Total time:   334 ms

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.72% 38354 / 48109
🔵 Statements 79.72% 38354 / 48109
🔵 Functions 77.3% 4107 / 5313
🔵 Branches 86.64% 9314 / 10749
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/src/utils/WalletUtil.ts 98.2% 93.15% 52.94% 98.2% 102-103, 178
Generated in workflow #16450 for commit 5c7737d by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] customWallets option does not have any effect

2 participants