Skip to content

Conversation

@svenvoskamp
Copy link
Contributor

@svenvoskamp svenvoskamp commented Dec 3, 2025

Description

Fix: show correct icon for continue with a wallet button

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-4154

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Note

Adds the wallet icon to the collapsed "Continue with a wallet" button and covers it with a unit test; includes a patch changeset.

  • UI (scaffold-ui):
    • Set icon="wallet" on wui-list-button in w3m-connect-view when collapseWallets is enabled.
  • Tests:
    • Add test in w3m-connect-view.test.ts asserting the collapse button renders with icon="wallet".
  • Release:
    • Add changeset for a patch to @reown/appkit-scaffold-ui.

Written by Cursor Bugbot for commit a712b98. This will update automatically on new commits. Configure here.

svenvoskamp added 30 commits May 6, 2025 09:33
@linear
Copy link

linear bot commented Dec 3, 2025

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2025

🦋 Changeset detected

Latest commit: a712b98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@reown/appkit-scaffold-ui Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-cdn Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-ton Patch
@reown/appkit-universal-connector Patch
@reown/appkit-experimental Patch
@reown/appkit-testing Patch
@reown/appkit-common Patch
@reown/appkit-ui Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-utils Patch
@reown/appkit-polyfills Patch
@reown/appkit-wallet Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet-button Patch
@reown/appkit-cli Patch
@reown/appkit-pay Patch
@reown/appkit-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Dec 3, 2025 9:17am
appkit-demo Ready Ready Preview Comment Dec 3, 2025 9:17am
appkit-gallery Ready Ready Preview Comment Dec 3, 2025 9:17am
appkit-headless-sample-app Ready Ready Preview Comment Dec 3, 2025 9:17am
appkit-laboratory Ready Ready Preview Comment Dec 3, 2025 9:17am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Dec 3, 2025 9:17am
appkit-basic-sign-client-example Ignored Ignored Dec 3, 2025 9:17am
appkit-basic-up-example Ignored Ignored Dec 3, 2025 9:17am
appkit-ethers5-bera Ignored Ignored Dec 3, 2025 9:17am
appkit-nansen-demo Ignored Ignored Dec 3, 2025 9:17am
appkit-vue-solana Ignored Ignored Dec 3, 2025 9:17am
appkit-wagmi-cdn-example Ignored Ignored Dec 3, 2025 9:17am
ethereum-provider-wagmi-example Ignored Ignored Dec 3, 2025 9:17am
next-wagmi-solana-bitcoin-example Ignored Ignored Dec 3, 2025 9:17am
vue-wagmi-example Ignored Ignored Dec 3, 2025 9:17am

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Visual Regression Test Results ✅ Passed

✨ No visual changes detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=477
Storybook Preview: https://6493191bf4b10fed8ca7353f-eaqnbanfgg.chromatic.com/

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit


> size-limit

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         71.36 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 247 ms   on Snapdragon 410
Total time:   1.7 s
@reown/appkit/react
Size limit:   230 kB
Size:         228.31 kB with all dependencies, minified and gzipped
Loading time: 4.5 s     on slow 3G
Running time: 922 ms    on Snapdragon 410
Total time:   5.4 s
@reown/appkit/vue
Size limit:   80 kB
Size:         71.36 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 401 ms   on Snapdragon 410
Total time:   1.8 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         209.41 kB with all dependencies, minified and gzipped
Loading time: 4.1 s     on slow 3G
Running time: 781 ms    on Snapdragon 410
Total time:   4.9 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms   on slow 3G
Running time: 38 ms    on Snapdragon 410
Total time:   295 ms

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.71% 38341 / 48097
🔵 Statements 79.71% 38341 / 48097
🔵 Functions 77.3% 4107 / 5313
🔵 Branches 86.63% 9307 / 10743
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/views/w3m-connect-view/index.ts 82.17% 82.1% 88.88% 82.17% 77-79, 82, 85-86, 90, 110, 158-159, 167, 173-174, 180, 214, 228, 239, 279, 283, 303, 317-318, 321-322, 333, 351-352, 357-381, 391-392
Generated in workflow #16448 for commit a712b98 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants