Skip to content

Conversation

@simaonogueira101
Copy link

@simaonogueira101 simaonogueira101 commented Dec 2, 2025

Description

Adds support for the new wallet_connect RPC method (ERC-7846) for Base Account connections in the Ethers and Ethers5 adapters.

Why wallet_connect over eth_requestAccounts?

While eth_requestAccounts (EIP-1102) still works, wallet_connect is the modern, recommended approach that offers:

  • Combined connection + authentication - Reduces user prompts from 2 to 1
  • Built-in SIWE support - Sign-In With Ethereum (ERC-4361) integration
  • Better UX - Streamlined single-step connection flow
  • Extensibility - Supports additional capabilities via ERC-5792

"By unifying connection and authentication into one step, apps can reduce friction, improve the user experience, and minimize redundant interactions." — ERC-7846

Changes

  • Added wallet_connect RPC method handling for Base Account connections in EthersAdapter
  • Added wallet_connect RPC method handling for Base Account connections in Ethers5Adapter
  • Updated error message to reflect "Base Account SDK" branding
  • Bumped @base-org/account to v2.5.0

Type of change

  • New feature (non-breaking change which adds functionality)

Associated Issues

Closes #5382

References

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

- Add wallet_connect RPC method handling for Base Account in EthersAdapter
- Add wallet_connect RPC method handling for Base Account in Ethers5Adapter
- Update error message to reflect Base Account SDK branding
- Bump @base-org/account to v2.5.0

The new wallet_connect method uses SIWE (Sign-In With Ethereum) capabilities
for authentication as documented in the Base Account SDK.

Reference: https://docs.base.org/base-account/quickstart/web
@vercel
Copy link

vercel bot commented Dec 2, 2025

@simaonogueira101 is attempting to deploy a commit to the Reown Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2025

🦋 Changeset detected

Latest commit: e875870

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-ton Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet-button Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-universal-connector Patch
@reown/appkit-testing Patch
@reown/appkit-common Patch
@reown/appkit-ui Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-polyfills Patch
@reown/appkit-wallet Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

All contributors have signed the CTA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@socket-security
Copy link

socket-security bot commented Dec 2, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​exodus/​bitcoin-wallet-standard@​0.0.0881006084100
Added@​radix-ui/​react-label@​2.1.71001006698100
Added@​radix-ui/​react-separator@​1.1.71001006798100
Added@​changesets/​changelog-github@​0.5.11001006789100
Added@​radix-ui/​react-slot@​1.2.31001006998100
Added@​radix-ui/​react-switch@​1.2.6991007096100
Added@​radix-ui/​react-tabs@​1.1.13991007098100
Added@​dnd-kit/​utilities@​3.2.21001007180100
Added@​chakra-ui/​icons@​2.2.61001007183100
Added@​radix-ui/​react-checkbox@​1.3.3991007196100
Added@​radix-ui/​react-radio-group@​1.3.8991007198100
Added@​babel/​preset-react@​7.27.11001007191100
Added@​esbuild-plugins/​node-globals-polyfill@​0.2.31001007180100
Added@​radix-ui/​react-accordion@​1.2.12991007198100
Added@​radix-ui/​react-dialog@​1.1.15991007196100
Added@​radix-ui/​react-tooltip@​1.2.8991007296100
Added@​radix-ui/​react-slider@​1.3.6991007298100
Added@​radix-ui/​react-select@​2.2.6991007498100
Added@​babel/​plugin-transform-runtime@​7.28.3991007492100
Added@​babel/​preset-env@​7.27.2971007792100
Added@​babel/​preset-env@​7.24.7961007792100
Added@​walletconnect/​sign-client@​2.23.0100100779780
Added@​dnd-kit/​core@​6.3.11001007982100
Added@​ethersproject/​sha2@​5.8.01001007981100
Added@​mailsac/​api@​1.0.8911009079100
Added@​dnd-kit/​sortable@​9.0.01001007981100
Added@​next/​third-parties@​15.2.11001008099100
Added@​bitcoinerlab/​secp256k1@​1.2.010010010081100
Added@​dnd-kit/​modifiers@​8.0.010010010081100
Added@​phosphor-icons/​webcomponents@​2.1.510010010082100
Added@​reown/​appkit-adapter-ethers@​1.8.0871008298100
Added@​reown/​appkit-adapter-solana@​1.8.0981008398100
Added@​reown/​appkit-adapter-bitcoin@​1.8.0961008498100
See 18 more rows in the dashboard

View full report

@simaonogueira101
Copy link
Author

I have read the CTA Document and I hereby sign the CTA

@simaonogueira101
Copy link
Author

recheck

@simaonogueira101 simaonogueira101 marked this pull request as ready for review December 2, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add wallet_connect (ERC-7846) support for Base Account connections

1 participant