fix: Added missing unsubscribe returns for sub functions in AppKit Core

[glitch-txs]

Description

Please include a brief summary of the change.

Type of change

• Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #5377

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

• Code in this PR is covered by automated tests (Unit tests, E2E tests)
• My changes generate no new warnings
• I have reviewed my own code
• I have filled out all required sections
• I have tested my changes on the preview link
• Approver of this PR confirms that the changes are tested on the preview link

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5e3692e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

@glitch-txs is attempting to deploy a commit to the Reown Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Thank you for your contribution! We ask that you please read and sign our CTA Document before we can accept your contribution. You can sign the CTA simply by posting a Pull Request Comment with the following text:

---

I have read the CTA Document and I hereby sign the CTA

---

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

[Copilot]

Pull request overview

This PR fixes a bug where two subscription methods (subscribeShouldUpdateToAddress and subscribeCaipNetworkChange) were missing return statements for their unsubscribe functions, and refactors subscribeAccount to properly aggregate and return all unsubscribe functions from its multiple controller subscriptions.

• Added return statements to subscribeShouldUpdateToAddress and subscribeCaipNetworkChange methods
• Refactored subscribeAccount to collect and return all unsubscribe functions via a cleanup function
• Added comprehensive tests to verify all subscribe methods return unsubscribe functions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
packages/appkit/src/client/appkit-base-client.ts	Added missing return statements for two subscribe methods and refactored subscribeAccount to properly aggregate unsubscribe functions
packages/appkit/tests/client/appkit-core.test.ts	Added comprehensive tests to verify all subscribe methods return unsubscribe functions and that cleanup works correctly

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[glitch-txs]

can we merge this one too? I'm needing it to handle some stuff programmatically inside a useEffect

cc @tomiir @magiziz

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
appkit-basic-html	Ready	Preview, Comment	Dec 15, 2025 2:10pm

2 Skipped Deployments

Project	Deployment	Review	Updated (UTC)
appkit-basic-example	Ignored		Dec 15, 2025 2:10pm
appkit-basic-sign-client-example	Ignored		Dec 15, 2025 2:10pm