You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements APKT-4175 to make batch call transaction parameters configurable in the AppKit laboratory app. Previously, all transaction test components used hardcoded addresses (vitalikEthAddress). This change allows Uniswap and other enterprise customers to customize transaction parameters including recipient address, amount, and transaction data.
Integrated AddTransactionModal for adding custom transactions to batch
Added UI to display transaction cards with amount, recipient, and optional data
Added ability to remove individual transactions from batch
Falls back to hardcoded TEST_TX_1 and TEST_TX_2 when no custom transactions
ESLint Fix
Fixed ESLint errors in AddTransactionModal.tsx that were causing CI build failures:
Added curly braces around if statement
Moved inline comment above code
Added newline before return statement
Added unicode flag (u) to regex
Associated Issues
Closes APKT-4175
Key Review Points
⚠️Type Assertions: The code uses type assertions between viem's Hex type and @reown/appkit-common's Hex type (e.g., args.data as Hex | undefined). Please verify these types are compatible.
⚠️Hex Validation: The regex /^0x[0-9a-fA-F]*$/u allows "0x" as valid input (empty data after prefix). This is intentional for optional fields but worth confirming.
⚠️Playwright Test Failures: 3 Playwright test shards failed (2, 6, 8) with network switching tests. These appear unrelated to the changes (no network switching logic was modified, and grep confirms no tests reference the changed button text). However, please review to confirm they're flaky tests.
⚠️UI Layout: New buttons added to transaction test pages. Please test on different screen sizes to ensure layout doesn't break.
Testing Notes
✅ All build, lint, typecheck, and Vercel deployment checks passed
✅ Local laboratory app build succeeded
✅ Code formatted with prettier
⚠️ 3 Playwright test shards failed with network switching tests (appear unrelated)
🔍 Manual testing recommended: Configure custom transactions in laboratory app and verify they execute correctly
Checklist
Code in this PR is covered by automated tests (existing Playwright tests cover transaction flows)
My changes generate no new warnings (all lint/typecheck passed)
I have reviewed my own code
I have filled out all required sections
I have tested my changes on the preview link (requires human verification)
Approver of this PR confirms that the changes are tested on the preview link
…ry app
APKT-4175: Implement configurable transaction parameters for Uniswap
Changes:
- Enhanced AddTransactionModal with optional data field and hex validation
- Added Simple/Advanced mode toggle with tooltips and help text
- Integrated configuration UI in WagmiTransactionTest and EthersTransactionTest
- Added transaction management to WagmiSendCallsTest with AddTransactionModal
- Updated EthersSendCallsTest to support optional data field
- All components now support custom recipient, amount, and transaction data
- Maintains backward compatibility with default hardcoded values
Co-Authored-By: enes@reown.com <enes@reown.com>
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@reown/appkit - Main Entry
Size limit: 80 kB
Size: 73.59 kB with all dependencies, minified and gzipped
Loading time: 1.5 s on slow 3G
Running time: 865 ms on Snapdragon 410
Total time: 2.4 s
@reown/appkit/react
Size limit: 230 kB
Size: 227.1 kB with all dependencies, minified and gzipped
Loading time: 4.5 s on slow 3G
Running time: 2.6 s on Snapdragon 410
Total time: 7 s
@reown/appkit/vue
Size limit: 80 kB
Size: 73.59 kB with all dependencies, minified and gzipped
Loading time: 1.5 s on slow 3G
Running time: 1.4 s on Snapdragon 410
Total time: 2.8 s
@reown/appkit-scaffold-ui
Size limit: 220 kB
Size: 207.84 kB with all dependencies, minified and gzipped
Loading time: 4.1 s on slow 3G
Running time: 2 s on Snapdragon 410
Total time: 6.1 s
@reown/appkit-ui
Size limit: 500 kB
Size: 13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms on slow 3G
Running time: 91 ms on Snapdragon 410
Total time: 348 ms
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements APKT-4175 to make batch call transaction parameters configurable in the AppKit laboratory app. Previously, all transaction test components used hardcoded addresses (vitalikEthAddress). This change allows Uniswap and other enterprise customers to customize transaction parameters including recipient address, amount, and transaction data.
Link to Devin run: https://app.devin.ai/sessions/db46fa811556478aabef7b6c3af9ac5f
Requested by: enes@reown.com
Type of change
What Changed
Core Changes
AddTransactionModal Enhancement (
apps/laboratory/src/components/AddTransactionModal.tsx):datafield for hex-encoded transaction data/^0x[0-9a-fA-F]*$/uonSubmitsignature to include optionaldata?: stringparameterSimple Transaction Components (
WagmiTransactionTest.tsx,EthersTransactionTest.tsx):Batch Transaction Components (
WagmiSendCallsTest.tsx,EthersSendCallsTest.tsx):ESLint Fix
Fixed ESLint errors in
AddTransactionModal.tsxthat were causing CI build failures:u) to regexAssociated Issues
Closes APKT-4175
Key Review Points
viem'sHextype and@reown/appkit-common'sHextype (e.g.,args.data as Hex | undefined). Please verify these types are compatible./^0x[0-9a-fA-F]*$/uallows "0x" as valid input (empty data after prefix). This is intentional for optional fields but worth confirming.Testing Notes
Checklist
Preview Links