Applying the changes in the SMIGRATED notification format #3868
+278
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the new format.
vladvildanov
reviewed
Dec 8, 2025
…ons flow for OSS Cluster API (#3869) * Adding handling of parallel slot migrations when OSS cluster api is used * Applying review comments
vladvildanov
approved these changes
Dec 8, 2025
petyaslavova
merged commit bc74454
into
feat/hitless_upgrade_sync_cluster_client
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the changed format of the SMIGRATED notification is applied.
The Proxy Mock helper needed some changes to generate the resp format of the messages.
Parser was changed, as well as the OSSNodeMigratedNotification fields - now the object contains a map with nodes host and port and slots.
Unit tests to related changes are also updated.
This is the format of the notification:
>3 +SMIGRATED :SeqID *<num_entries> *2 +<host:port> +<slots-or-ranges>