dial: return early on successful initial dial instead of blocking via sleep unconditionally #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sleep unconditionally Dial should not unconditionally sleep for that amount of time. If the conection succeeded via the asynchronous goroutine, we can simply return early. This is particularly helpful in situations where one needs a higher handshake timeout, because now Dial won't just block for the full amount of time, allowing the program to move on to other work.
Author
|
@loeffel-io opened this PR per your request. As mentioned in the PR description, this change is unfortunately un-tested. Feel free to modify as needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dial should not unconditionally sleep for that amount of time. If the conection succeeded via the asynchronous goroutine, we can simply return early.
This is particularly helpful in situations where one needs a higher handshake timeout, because now Dial won't just block for the full amount of time, allowing the program to move on to other work.
NOTE: This code is not tested; unfortunately we stopped using this library so I never got a chance to use or test this code. Sorry about that!