Skip to content

Conversation

@jzeuzs
Copy link
Contributor

@jzeuzs jzeuzs commented Sep 27, 2025

Resolves #635.

@mikewesthad mikewesthad added the release/patch Author patch release label Oct 1, 2025
Copy link
Contributor

@mikewesthad mikewesthad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things but otherwise LGTM. I think being able to do:

echo "TEST=123" | cargo run variables

W/o the flag is a little cleaner, but I think what you have with an explicit flag is probably best here for backwards compat

@jzeuzs
Copy link
Contributor Author

jzeuzs commented Nov 8, 2025

Couple small things but otherwise LGTM. I think being able to do:

echo "TEST=123" | cargo run variables

W/o the flag is a little cleaner, but I think what you have with an explicit flag is probably best here for backwards compat

I think having an explicit flag would be better.

@jzeuzs jzeuzs requested a review from mikewesthad November 8, 2025 10:23
@ndneighbor
Copy link
Contributor

Going to work on Milo's, and then yours after this one, but keeping an eye on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/patch Author patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: ability to set secret variables from CLI and read values from stdin

4 participants