detect and warn about x64 R on Windows ARM #13790
Draft
+143
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Detects x64 R running on Windows ARM and provides helpful error message with ARM64 R download guidance instead of generic installation message. Implementation details: - Parses YAML output to detect architecture mismatch - Uses custom WindowsArmX64RError for type-safe error handling - Detects in both success and failure paths (emulation is intermittent) - Ensures error displays in quarto check output 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Deno.build.arch reports x86_64 even when x64 Deno runs on ARM64 hardware under emulation. Use Windows IsWow64Process2 API via FFI to detect the actual native hardware architecture. This fixes the x64-on-ARM detection so the custom error message displays instead of the generic "Please check your installation of R" message. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Performance improvements: - Check isX64R first to short-circuit when R is ARM64 (correct setup) - Only check ARM architecture when R fails (x64 R on ARM always crashes) - Avoids FFI overhead for all successful R checks Documentation: - Explains why kernel32.dll FFI is needed and safe - Links to validation repo and Microsoft API docs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When x64 R fails on Windows ARM, parse YAML output to detect the architecture mismatch and provide a specific error message with ARM64 R download links instead of the generic "check your R installation" message.
Also adds platform information to quarto check output with warning when x64 R is detected on ARM Windows.
This is draft PR because I need to check this work as expected in windows ARM runner