-
Notifications
You must be signed in to change notification settings - Fork 5
K-PKE #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Marvin-Beckmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a few comments that could be added in my opinion
| // 5 𝐀[𝑖,𝑗] ← SampleNTT(𝜌‖𝑗‖𝑖) | ||
| let mat_a = MatPolynomialRingZq::sample_uniform(self.k, self.k, &self.q); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sampling in NTT transform and plain coefficients is not necessarily the same. For uniform it is the same - maybe add a small comment or sth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should however add a comment, that we leave out the NTT here for simplicitly, because in formal algorithm 14 for K-PKE, the Matrix A is in NTT transform, so, maybe we should add a specific comment that A is not in NTT-form, as this might otherwise be quite confusing, similarly s and e
| /// | ||
| /// This implementation is not supposed to be an implementation of the FIPS 203 standard, but | ||
| /// is supposed to showcase the prototyping capabilities of `qfall` and does not cover compression algorithms | ||
| /// as specified in the FIPS 203 document or might deviate for the choice of matrix multiplication algorithms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could link the document in the same fashion we have done it so far for papers
Co-authored-by: Marvin Beckmann <mabeck@dtu.dk>
Description
This PR implements...
Testing
Checklist:
Performance results on my laptop