-
Notifications
You must be signed in to change notification settings - Fork 2
Scalar mul assign #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Scalar mul assign #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsiemer
approved these changes
Oct 9, 2025
Member
jnsiemer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Found several small issues (almost nothing functional, mostly documentation consistency). Please take the time to check all marked bugs yourself across the documents. I've spotted some comparatively late in the review.
src/integer_mod_q/mat_polynomial_ring_zq/arithmetic/mul_scalar.rs
Outdated
Show resolved
Hide resolved
src/integer_mod_q/mat_polynomial_ring_zq/arithmetic/mul_scalar.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements MulAssign for scalars of
It also implements the following DivAssign (and small fixes in Div)
Testing
I decided against adding a complete test coverage for all combinations of borrowed and owned, and I did not manually check all div by 0 errors that I could find, as that is not needed, and also covered in flint itself (it returns an error from there, just not a classical panic from rust, but the program is terminated regardless).
Checklist: