Update get_committer_data for latest PyGithub #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.55 of PyGithub changed `get_emails` to return a named tuple (#1890) rather than a dict directly from the decoded API response. Update the code to access the fields as a property rather than by index & bump the pin so 1.55 is the minimum version. Also update the existing tests for the now required `headers` parameter on exception classes.
DamianZaremba
force-pushed
the
support-latest-pygithub
branch
from
64a0df9 to
f5ed496
Compare
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
+ Coverage 94.24% 94.32% +0.08%
==========================================
Files 11 11
Lines 1164 1164
==========================================
+ Hits 1097 1098 +1
+ Misses 67 66 -1
Continue to review full report at Codecov.
|
Python 3.5 has been EOL since Sept 2020, 10 months ago at this point. The latest release of PyGithub does not support 3.5 (#1770), thus remove the support here also. Also add test cases for Python 3.9, which is the current stable release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.55 of PyGithub changed
get_emailsto return a named tuple (#1890)rather than a dict directly from the decoded API response.
Update the code to access the fields as a property rather than by index
& bump the pin so 1.55 is the minimum version.
Fixes #409