Skip to content

Cortex_m backend: Add softmax support for int8 via CMSIS NN (dim=-1) #16152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AdrianLundell merged 1 commit into from
Dec 19, 2025
Merged

Cortex_m backend: Add softmax support for int8 via CMSIS NN (dim=-1) #16152

AdrianLundell merged 1 commit into from
Dec 19, 2025

Conversation

@xingguo01
Copy link
Contributor

@xingguo01 xingguo01 commented Dec 9, 2025 •
edited
Loading

  • integrate CMSIS softmax into Cortex-M backend
  • add fusion pass/tests for quantized softmax

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai @Sebastian-Larsson @AdrianLundell @psiddh

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16152

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit c0b5684 with merge base 0fb422f (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 9, 2025
@xingguo01
Copy link
Contributor Author

xingguo01 commented Dec 9, 2025

@pytorchbot label "ciflow/trunk","partner:arm","release notes:arm"

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2025

To add these label(s) (ciflow/trunk,partner:arm,release notes:arm) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@xingguo01
Copy link
Contributor Author

xingguo01 commented Dec 9, 2025

@pytorchbot label "ciflow/trunk","partner:arm","release notes:arm"

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2025

Didn't find following labels among repository labels: ciflow/trunk,partner:arm,release notes:arm

@xingguo01
Copy link
Contributor Author

xingguo01 commented Dec 9, 2025

@pytorchbot label "ciflow/trunk"

@xingguo01
Copy link
Contributor Author

xingguo01 commented Dec 9, 2025

@pytorchbot label "partner:arm" "release notes:arm"

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2025

Didn't find following labels among repository labels: partner:arm,release notes:arm

@xingguo01
Copy link
Contributor Author

xingguo01 commented Dec 9, 2025

@pytorchbot label "partner:arm"

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2025

Didn't find following labels among repository labels: partner:arm

@xingguo01
Copy link
Contributor Author

xingguo01 commented Dec 9, 2025

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Dec 9, 2025
@xingguo01
Copy link
Contributor Author

xingguo01 commented Dec 9, 2025

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot bot added the release notes: arm Changes to the ARM backend delegate label Dec 9, 2025
@pytorch-bot pytorch-bot bot removed the ciflow/trunk label Dec 9, 2025
@xingguo01 xingguo01 marked this pull request as ready for review December 9, 2025 13:56
@xingguo01 xingguo01 changed the title Add softmax support for int8 in Cortex M (dim=-1) Cortex_m backend: Add softmax support for int8 in Cortex M (dim=-1) Dec 9, 2025
@xingguo01 xingguo01 changed the title Cortex_m backend: Add softmax support for int8 in Cortex M (dim=-1) Cortex_m backend: Add softmax support for int8 via CMSIS NN (dim=-1) Dec 9, 2025
@xingguo01
Copy link
Contributor Author

xingguo01 commented Dec 9, 2025

@psiddh much appreciated if you can have a look

@xingguo01 xingguo01 force-pushed the cortex-m-softmax branch 2 times, most recently from 19a3ec8 to 6379fd6 Compare December 11, 2025 09:21
@AdrianLundell AdrianLundell requested a review from psiddh December 11, 2025 09:56
psiddh
psiddh approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@psiddh psiddh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xingguo01
Add softmax support for int8 in Cortex M (dim=-1)
c0b5684 
- integrate CMSIS softmax into Cortex-M backend
- add fusion pass/tests for quantized softmax
- lint cleanup passes
- Resolved merge conflicts

Change-Id: I0ec19f011069fa1482e2de2ab62b9e7d7f56b2a8
Signed-off-by: Xingguo Li <xingguo.li@arm.com>
@AdrianLundell
Copy link
Collaborator

AdrianLundell commented Dec 19, 2025

Failures unrelated

@AdrianLundell AdrianLundell merged commit 09103d9 into pytorch:main Dec 19, 2025
136 of 139 checks passed
@github-project-automation github-project-automation bot moved this from To triage to Done in ExecuTorch Embedded Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psiddh psiddh psiddh approved these changes

@rascani rascani rascani left review comments

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@AdrianLundell AdrianLundell Awaiting requested review from AdrianLundell

@digantdesai digantdesai Awaiting requested review from digantdesai

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

ExecuTorch Embedded
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xingguo01 @AdrianLundell @psiddh @rascani