Add docs label for markdown files #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #657 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 2149 2149
Branches 97 97
=========================================
Hits 2149 2149
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
AA-Turner
approved these changes
Dec 8, 2024
AA-Turner
changed the title
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
ezio-melotti
reviewed
Dec 8, 2024
|
|
||
| async def test_docs_no_news(): | ||
| filenames = {"path/to/docs1.rst"} | ||
| filenames = {"path/to/docs1.rst", "other/path/to/docs2.md"} |
Member
There was a problem hiding this comment.
Wouldn't this test pass even without the changes in prtype.py?
The filenames include an .rst file, so the docs label should be applied regardless.
I would suggest to verify this, and possibly turn the list of filenames into a fixture.
Contributor
Author
There was a problem hiding this comment.
Wouldn't this test pass even without the changes in prtype.py?
No. In this case classify_by_filepaths() will quickly return an empty list, walking over filenames (else branch).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #656