Skip to content

Adds performance panel to storybook #7345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattcosta7 wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −0
Open

Adds performance panel to storybook #7345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
806adb9
publish storybook perf panel
mattcosta7 Dec 16, 2025
16fd141
update
mattcosta7 Dec 19, 2025
dfd17a3
Merge remote-tracking branch 'origin/main' into storybook-perf-panel
mattcosta7 Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"@github/markdownlint-github": "^0.8.0",
"@github/mini-throttle": "2.1.1",
"@github/prettier-config": "0.0.6",
"@github-ui/storybook-addon-performance-panel": "0.1.2",
"@mdx-js/react": "1.6.22",
"@playwright/test": "^1.56.1",
"@prettier/sync": "0.5.5",
Expand Down
1 change: 1 addition & 0 deletions packages/react/.storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const config: StorybookConfig = {
getAbsolutePath('@storybook/addon-a11y'),
getAbsolutePath('@storybook/addon-links'),
getAbsolutePath('@storybook/addon-docs'),
'@github-ui/storybook-addon-performance-panel',
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addon is not using the getAbsolutePath() helper function like the other Storybook addons on lines 20-22. This is inconsistent with the established pattern in this configuration file. Consider wrapping it with getAbsolutePath() for consistency.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@mattcosta7 mattcosta7 Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getAbolute seems to fail fo rhtis - not sure why - are they needed?

Copy link
Contributor

@liuliu-dev liuliu-dev Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the reason is that storybook looks for manager.js or preview.js or preset.js at the package root (https://github.com/storybookjs/storybook/blob/main/code/core/src/common/presets.ts#L81)

If the storybook-addon-performance-panel re-exports one of them at the package root, getAbsolutePath() would work. But I think using just '@github-ui/storybook-addon-performance-panel' should be fine.

],

framework: {
Expand Down
Loading