-
Notifications
You must be signed in to change notification settings - Fork 23
feat(pkg-r): SQL tibble sources (TblSqlSource) #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
Dec 15, 2025
cpsievert
reviewed
Dec 15, 2025
cpsievert
reviewed
Dec 15, 2025
cpsievert
reviewed
Dec 15, 2025
cpsievert
reviewed
Dec 15, 2025
gadenbuie
commented
Dec 16, 2025
These were developed for tbl_sql, but are broadly useful, so we're including the guidelines generally if either query tool is included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
How does this work?
Simple tbl source
First, we can create a new data source from the
tbl()object.Which returns a
tbl()that can be chained into furtherdplyroperations.Complicated tbl source
This same process even works for more complicated tibbles, like the result of
of dplyr pipeline on SQL tibbles.
And again, the result is a
tbl()that can be folded into further dplyroperations.
The way we make this work is by extracting the SQL for the dplyr pipeline up
until we create a data source, and then, for complicated queries at least, we
use a local CTE, letting the LLM write queries against that CTE as if it were
a fixed table.
Amazingly, we can even apply this strategy to get the schema of the CTE. This
took a small amount of updating to
get_schema_impl()to make it work, butthe core logic is exactly the same.