refactor: rename the router controller to 'find' for fetching with a …

[boazpoolman]

…read-only API token

What does it do?

It renames the router controller from 'router' to 'find'. I've added backwards compatibility for anybody using the controller on their own custom endpoint. This will be removed in the next major version.

Why is it needed?

To make the endpoint accessible when using a read-only API token.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

#309 #7

[changeset-bot]

🦋 Changeset detected

Latest commit: 8f64cef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
webtools-addon-sitemap	Patch
strapi-plugin-webtools	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[boazpoolman]

This actually seems to be a breaking change. I didn't realize that permissions are given to the controller, not the route. So renaming the controller will reset existing permissions. This will need a major version bump and will for that reason be postponed.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.89%. Comparing base (0625149) to head (2fd0445).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   38.89%   38.89%           
=======================================
  Files           2        2           
  Lines         653      653           
  Branches      163      163           
=======================================
  Hits          254      254           
  Misses        317      317           
  Partials       82       82           

Flag	Coverage Δ
unit	38.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[SalahAdDin]

@boazpoolman can you fix the conflicts here?

[boazpoolman]

@boazpoolman can you fix the conflicts here?

@SalahAdDin I can, but I'm not merging this PR just yet as it is not such a critical feature and it does introduce a breaking change.

[SalahAdDin]

@boazpoolman can you fix the conflicts here?

@SalahAdDin I can, but I'm not merging this PR just yet as it is not such a critical feature and it does introduce a breaking change.

Quality code, technical debt may be 😅?