Skip to content

Conversation

@bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Dec 25, 2025

Currently, PD updates the bucket metadata from the report bucket stream. It causes there to be two functions to change the region meta, and causes the bucket meta to be stale, but the region meta is the latest.

Signed-off-by: tongjian <1045931706@qq.com>
Signed-off-by: tongjian <1045931706@qq.com>
Signed-off-by: tongjian <1045931706@qq.com>
Signed-off-by: tongjian <1045931706@qq.com>
Signed-off-by: tongjian <1045931706@qq.com>
@ti-chi-bot ti-chi-bot bot added the size/XXL label Dec 25, 2025
Signed-off-by: tongjian <1045931706@qq.com>
@bufferflies bufferflies changed the title Region heartbeat with bucket Region heartbeat with bucket meta info Dec 26, 2025
@bufferflies
Copy link
Contributor Author

friendly ping @rleungx

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rleungx
Copy link
Member

rleungx commented Dec 29, 2025

/cc @overvenus @ekexium

@ti-chi-bot ti-chi-bot bot requested review from ekexium and overvenus December 29, 2025 07:23
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 29, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-26 01:38:53.563718208 +0000 UTC m=+2387478.377495779: ☑️ agreed by disksing.
  • 2025-12-29 08:51:01.433410598 +0000 UTC m=+1017.251719030: ☑️ agreed by pingyu.

@pingyu
Copy link
Contributor

pingyu commented Dec 29, 2025

cc @coocood

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coocood, disksing, overvenus, pingyu, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 6, 2026
@bufferflies bufferflies merged commit 438649d into pingcap:master Jan 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants