-
Notifications
You must be signed in to change notification settings - Fork 8k
ext/sockets: adding Linux's TCP_USER_TIMEOUT constant. #20708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucasnetau
wants to merge
6
commits into
php:master
Choose a base branch
from
lucasnetau:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Dec 15, 2025
devnexen
reviewed
Dec 16, 2025
devnexen
reviewed
Dec 16, 2025
devnexen
reviewed
Dec 16, 2025
devnexen
reviewed
Dec 16, 2025
|
|
||
| #if defined(TCP_USER_TIMEOUT) | ||
| case TCP_USER_TIMEOUT: { | ||
| ov = zval_get_long(arg4); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, I realise ov is an int.
you would need the following change
zend_long timeout = zval_get_long(arg4);
<overflow check on timeout>
unsigned int val = (unsigned int)timeout;
optlen = sizeof(val);
opt_ptr = &val;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to ensure PHP sockets are notified of socket failure when Sockets may be closed incorrectly and data can no longer be transmitted. eg Firewall dropping connection or peer device failure (commonly seen with Cloud load balancers).
From tcp(7) :It specifies the maximum amount of time in milliseconds that transmitted data may remain unacknowledged, or buffered data may remain untransmitted (due to zero window size) before TCP will forcibly close the corresponding connection and return ETIMEDOUT to the application.
Following #13816 for PR format for socket constants/