[FEATURE] Selection provider #539
Conversation
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
table/src/Table.ts
Outdated
| { label: 'Column Settings', content: TableColumnsEditor }, | ||
| { label: 'Cell Settings', content: TableCellsEditor }, | ||
| { label: 'Transforms', content: TableTransformsEditor }, | ||
| { label: 'Selections', content: TableSelectionsEditor }, |
There was a problem hiding this comment.
I find it a bit overkill to have a whole new tab in the panel settings that allows to tune a single attribute in the end. Could we make it a sub-section of the General Settings instead?
There was a problem hiding this comment.
Yeah, I agree. I think it could be put in General settings or directly in Item Actions
There was a problem hiding this comment.
Added a single editor for both selections and actions
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
jgbernalp
force-pushed
the
selection-provider
branch
from
da2e0c7 to
1ddc65e
Compare
table/src/components/index.ts
Outdated
| export * from './TableColumnsEditor'; | ||
| export * from './TableItemSelectionActionsEditor'; | ||
| export * from './TablePanel'; | ||
| export * from './TableSelectionsEditor'; |
| import ( | ||
| "strings" | ||
| "github.com/perses/shared/cue/common" | ||
| commLocal "github.com/perses/local/cue/common" |
There was a problem hiding this comment.
I guessing there is a trick here for the import (like npm link for cue I guess), because I have an issue with percli plugin start table: import is failing 🤔
Not important for reviewing the UI (shared), I removed lines causing issues 👍
There was a problem hiding this comment.
yes, this is for testing locally as the shared cue package does not have the required selection and actions schemas. Without this the panel will fail to save. Basically in my repo I have:
Note this folder is ignored for Git
This is the trick I found in cue. I was able to use a local schema to allow perses API to validate and store the proper schema.
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
jgbernalp
force-pushed
the
selection-provider
branch
from
1ddc65e to
b387681
Compare
Description
Related to: perses/perses#3788
Requires: perses/shared#40
Screenshots
// TODO
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes