Skip to content

update devcontainer #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andreialecu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update devcontainer #442

andreialecu wants to merge 1 commit into from
+43 −69

Conversation

@andreialecu
Copy link

@andreialecu andreialecu commented Jun 27, 2025

This was required to fix the following error:

== Compilation error in file extra/keila/license/license.ex ==
** (FunctionClauseError) no function clause matching in :public_key.der_decode/2    
    
    The following arguments were given to :public_key.der_decode/2:
    
        # 1
        :EcpkParameters
    
        # 2
        :asn1_NOVALUE
    
    (public_key 1.14) public_key.erl:332: :public_key.der_decode/2
    (public_key 1.14) public_key.erl:225: :public_key.pem_entry_decode/1
    extra/keila/license/license.ex:18: (module)
    (elixir 1.15.1) lib/kernel/parallel_compiler.ex:377: anonymous fn/5 in Kernel.ParallelCompiler.spawn_workers/8

It appears it requires an updated Elixir versus what was pinned to the devcontainer.

wmnnd
wmnnd requested changes Jun 27, 2025
View reviewed changes
.devcontainer/Dockerfile
ARG PHOENIX_VERSION="1.7.10"
RUN mix local.hex --force \
&& mix local.rebar --force \
&& mix archive.install --force hex phx_new ${PHOENIX_VERSION}
Copy link
Contributor

@wmnnd wmnnd Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary to install phx_new because there's no need to create a new Phoenix project here :-)

.devcontainer/Dockerfile
&& mix local.rebar --force \
&& mix archive.install --force hex phx_new ${PHOENIX_VERSION}"
ARG ELIXIR_VERSION="1.15.8"
FROM elixir:${ELIXIR_VERSION}
Copy link
Contributor

@wmnnd wmnnd Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the Elixir image seems like a good idea to simplify things!

@wmnnd wmnnd force-pushed the main branch 2 times, most recently from f9adb61 to 455250a Compare January 4, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmnnd wmnnd wmnnd requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andreialecu @wmnnd