-
Notifications
You must be signed in to change notification settings - Fork 1
Update health check command to use port 8080 #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🚀 env0 had composed a PR Plan for environment Terraform Example / production : Plan DetailsTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
! update in-place
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.scenarios[0].aws_ecs_service.face will be updated in-place
! resource "aws_ecs_service" "face" {
id = "arn:aws:ecs:eu-west-2:540044833068:service/example-terraform-example/facial-recognition"
name = "facial-recognition"
tags = {}
! task_definition = "arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example:9" -> (known after apply)
# (15 unchanged attributes hidden)
# (5 unchanged blocks hidden)
}
# module.scenarios[0].aws_ecs_task_definition.face must be replaced
-/+ resource "aws_ecs_task_definition" "face" {
! arn = "arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example:9" -> (known after apply)
! arn_without_revision = "arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example" -> (known after apply)
! container_definitions = jsonencode(
! [
! {
! healthCheck = {
! command = [
"CMD-SHELL",
- "wget -q --spider localhost:1234",
+ "wget -q --spider localhost:8080",
]
# (3 unchanged attributes hidden)
}
name = "facial-recognition"
! portMappings = [
! {
- hostPort = 1234
- protocol = "tcp"
# (2 unchanged attributes hidden)
},
]
- systemControls = []
# (7 unchanged attributes hidden)
},
] # forces replacement
)
! enable_fault_injection = false -> (known after apply)
! id = "facial-recognition-terraform-example" -> (known after apply)
! revision = 9 -> (known after apply)
- tags = {} -> null
! tags_all = {} -> (known after apply)
# (7 unchanged attributes hidden)
}
# module.scenarios[0].aws_rds_cluster.face_database will be updated in-place
! resource "aws_rds_cluster" "face_database" {
id = "facial-recognition-terraform-example"
tags = {}
# (46 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 1 to add, 2 to change, 1 to destroy.
╷
│ Warning: Argument is deprecated
│
│ with aws_iam_role.deploy_role,
│ on terraform.tf line 56, in resource "aws_iam_role" "deploy_role":
│ 56: resource "aws_iam_role" "deploy_role" {
│
│ inline_policy is deprecated. Use the aws_iam_role_policy resource instead.
│ If Terraform should exclusively manage all inline policy associations (the
│ current behavior of this argument), use the aws_iam_role_policies_exclusive
│ resource as well.
│
│ (and 4 more similar warnings elsewhere)
╵
╷
│ Warning: Most Recent Image Not Filtered
│
│ with module.scenarios[0].data.aws_ami.amazon_linux,
│ on modules/scenarios/main.tf line 2, in data "aws_ami" "amazon_linux":
│ 2: data "aws_ami" "amazon_linux" {
│
│ "most_recent" is set to "true" and results are not filtered by owner or
│ image ID. With this configuration, a third party may introduce a new image
│ which will be returned by this data source. Consider filtering by owner or
│ image ID to avoid this possibility.
╵ |
Open in Overmind ↗
🔴 Change SignalsRoutine 🔴 🔥 RisksHealth check changed to 8080 while service and ALB remain on 1234 will mark tasks unhealthy and drop ALB targets When the change deploys, the ECS agent will execute the health check against port 8080, where the application is not listening. Containers will be reported unhealthy and restarted, causing their deregistration from the target group and leaving no healthy targets for the load balancer. This will break traffic routing and result in service unavailability until the health check matches the actual listening port or the service is moved end‑to‑end to 8080. 🟣 Expected Changes+/- ecs-task-definition › facial-recognition-terraform-example--- current
+++ proposed
@@ -2,17 +2,23 @@
id: github.com/overmindtech/terraform-example.ecs-task-definition.module.scenarios[0].aws_ecs_task_definition.face
attributes:
- arn: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example:9
- arn_without_revision: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example
- container_definitions: '[{"cpu":1024,"environment":[{"name":"DATABASE_URL","value":"tf-20251117235257281600000001.cnx7xf6hwmba.eu-west-2.rds.amazonaws.com"}],"essential":true,"healthCheck":{"command":["CMD-SHELL","wget -q --spider localhost:1234"],"interval":30,"retries":3,"timeout":5},"image":"harshmanvar/face-detection-tensorjs:slim-amd","memory":2048,"mountPoints":[],"name":"facial-recognition","portMappings":[{"appProtocol":"http","containerPort":1234,"hostPort":1234,"protocol":"tcp"}],"systemControls":[],"volumesFrom":[]}]'
+ arn: (known after apply)
+ arn_without_revision: (known after apply)
+ container_definitions: '[{"cpu":1024,"environment":[{"name":"DATABASE_URL","value":"tf-20251117235257281600000001.cnx7xf6hwmba.eu-west-2.rds.amazonaws.com"}],"essential":true,"healthCheck":{"command":["CMD-SHELL","wget -q --spider localhost:8080"],"interval":30,"retries":3,"timeout":5},"image":"harshmanvar/face-detection-tensorjs:slim-amd","memory":2048,"mountPoints":[],"name":"facial-recognition","portMappings":[{"appProtocol":"http","containerPort":1234}],"volumesFrom":[]}]'
cpu: "1024"
- enable_fault_injection: false
+ enable_fault_injection: (known after apply)
+ execution_role_arn: null
family: facial-recognition-terraform-example
- id: facial-recognition-terraform-example
+ id: (known after apply)
+ ipc_mode: null
memory: "2048"
network_mode: awsvpc
+ pid_mode: null
requires_compatibilities:
- FARGATE
- revision: 9
+ revision: (known after apply)
skip_destroy: false
+ tags: null
+ tags_all: (known after apply)
+ task_role_arn: null
terraform_address: module.scenarios[0].aws_ecs_task_definition.face
terraform_name: module.scenarios[0].aws_ecs_task_definition.face
🟠 Unmapped Changes~ aws_ecs_service › module.scenarios[0].aws_ecs_service.face--- current
+++ proposed
@@ -38,5 +38,5 @@
propagate_tags: NONE
scheduling_strategy: REPLICA
- task_definition: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example:9
+ task_definition: (known after apply)
terraform_address: module.scenarios[0].aws_ecs_service.face
terraform_name: module.scenarios[0].aws_ecs_service.face
💥 Blast RadiusItems Edges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛔ Auto-Blocked
🔴 Decision
Found 1 high risk requiring review
📊 Signals Summary
Routine 🔴 -5
🔥 Risks Summary
High 1 · Medium 0 · Low 0
💥 Blast Radius
Items 19 · Edges 56


No description provided.