-
Notifications
You must be signed in to change notification settings - Fork 6
IHS-183: Fix typing errors for protocols #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request converts Protocol-based type definitions to concrete base classes and updates related type handling throughout the SDK. Changes include removing 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
6c5bd98
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5101b420.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://re-sb-20260119-fix-typing-fo.infrahub-sdk-python.pages.dev |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## develop #763 +/- ##
===========================================
+ Coverage 80.32% 80.38% +0.05%
===========================================
Files 115 115
Lines 9888 9894 +6
Branches 1520 1517 -3
===========================================
+ Hits 7943 7953 +10
- Misses 1417 1418 +1
+ Partials 528 523 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes #697
Replace protocols with concrete classes to address type-abstract mypy errors
Summary by CodeRabbit
Refactor
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.