Skip to content

Conversation

@BKPepe
Copy link
Member

@BKPepe BKPepe commented Dec 29, 2025

Maintainer: @jmarcet
Compile tested: will be done inside CI/CD
Run testing: NO, since I do not have riscv64 device.

This adds support RISC-V64 to luajit2 by backporting https://redirect.github.com/openresty/luajit2/pull/236

Fixes: #27611

Copilot AI review requested due to automatic review settings December 29, 2025 08:40
@BKPepe BKPepe mentioned this pull request Dec 29, 2025
7 tasks
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to add RISC-V64 architecture support to the luajit2 package by backporting changes from openresty/luajit2#236. The change updates the architecture configuration to include riscv64 in the list of supported platforms.

Key Changes:

  • Added riscv64 to the HAS_LUAJIT_ARCH configuration option in the Makefile

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

config HAS_LUAJIT_ARCH
bool
default y if i386||x86_64||arm||armeb||aarch64||powerpc||mips||mipsel||mips64
default y if i386||x86_64||arm||armeb||aarch64||powerpc||mips||mipsel||mips64||riscv64
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding riscv64 to the HAS_LUAJIT_ARCH configuration without including the necessary patches for RISC-V64 support will likely cause build failures. The PR description mentions backporting https://redirect.github.com/openresty/luajit2/pull/236, but no corresponding patch files are present in the patches directory. The actual RISC-V64 support patches need to be added to lang/lua/luajit/patches/ before enabling this architecture in the configuration.

Suggested change
default y if i386||x86_64||arm||armeb||aarch64||powerpc||mips||mipsel||mips64||riscv64
default y if i386||x86_64||arm||armeb||aarch64||powerpc||mips||mipsel||mips64

Copilot uses AI. Check for mistakes.
This adds support RISC-V64 to luajit2 by backporting
https://redirect.github.com/openresty/luajit2/pull/236

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
@BKPepe
Copy link
Member Author

BKPepe commented Dec 29, 2025

Okay, I see that riscv64 is now compiled for luajit2, but it fails for luajit and that is why it is failing in the CI/CD check. We need that logic, but that can be done later. Merging.

@BKPepe BKPepe merged commit 47525f3 into openwrt:master Dec 29, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

luajit2: does not support riscv64

1 participant