[cli] better definition of background CLI commands + add more background commands

[EskoDijk]

Some OT CLI commands were missing as 'background' commands - this adds a few.
Also the list of background commands is more clear now with one command per line.

[gemini-code-assist]

Summary of Changes

Hello @EskoDijk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines how background CLI commands are identified and managed within the system. It introduces a more structured approach to defining these commands and expands the set of commands that are recognized as background operations, ensuring better command handling and system responsiveness.

Highlights

• Improved Background Command Definition: The definition of CLI background commands has been refactored from a single regular expression into an explicit string slice, enhancing readability and maintainability.
• Expanded Background Command List: Several new OpenThread CLI commands have been added to the list of recognized background commands, including various DNS, Link Metrics, Mesh Diagnostics, MLR, P2P, and SNTP commands.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/develop.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the definition of background CLI commands by moving them to a string slice, which greatly improves maintainability and readability. It also correctly expands the list of recognized background commands. This is a solid improvement. I have one suggestion to make the regular expression generation even more robust.

[EskoDijk]

@jwhui Just fixed and rebased this PR - should now be ready to review. This adds more OT CLI commands (that run in the 'background' producing results onto the CLI) to the set of working background commands.

[EskoDijk]

@jwhui Issue in the commits was fixed 4 days ago (there was a test commit unintentionally included). Now ready for approval or another review if needed.

[jwhui]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors the definition of background CLI commands, making them clearer and easier to maintain by moving them into a string slice. It also expands the list of background commands. The logic for handling these commands is improved to correctly identify when a potential background command behaves like a foreground command by returning 'Done' immediately. New tests have been added to cover this new functionality.

I've found a couple of minor issues: one in the implementation of background command detection logic which could fail with certain output formats, and another in the test suite with an incorrect assertion. My review includes suggestions to fix these.

[EskoDijk]

@jwhui Now updated based on the last Gemini review comments.

[EskoDijk]

@jwhui We have 2 test failures on the compiled (webpack) Javascript result, but this PR doesn't change anything there!
This might be due to some change of support level for the webpack/JS/nodejs tools available on the web? E.g. our CI may request an old version of certain libraries and that version got auto-replaced by a newer one.
(Or someone's injected a malicious version of a JS library somewhere ... heard about such things)

In any case it shouldn't affect this PR I think.

[EskoDijk]

... We have 2 test failures on the compiled (webpack) Javascript result, but this PR doesn't change anything there! This might be due to some change of support level for the webpack/JS/nodejs tools available on the web? ...

Now created issue #737 to record the details for this issue. Not related to the present PR.