Skip to content

Conversation

@Inquinim
Copy link

@Inquinim Inquinim commented Aug 2, 2023

There are a lot of validators that deregister from the network but continue forwarding requests which floods the network. A simple metagraph lookup should solve the issue.

@ifrit98 @shibshib

@p-ferreira
Copy link
Contributor

This change adds a component to put the validator to sleep in case it gets deregistered, which it will continue until the validator gets registered again, skipping the processing steps while not registered.

It seems ok for me, unless we want to explicitly stop the validator operation whenever it gets deregistered.
@Eugene-hu @opentaco @isabella618033 @steffencruz any thoughts about merging this change?

@p-ferreira p-ferreira changed the base branch from main to staging August 21, 2023 19:05
@Eugene-hu
Copy link
Contributor

This change adds a component to put the validator to sleep in case it gets deregistered, which it will continue until the validator gets registered again, skipping the processing steps while not registered.

It seems ok for me, unless we want to explicitly stop the validator operation whenever it gets deregistered. @Eugene-hu @opentaco @isabella618033 @steffencruz any thoughts about merging this change?

I agree, I think if a validator gets deregistered, it should instead break and stop the script rather than sleep forever

@steffencruz
Copy link
Contributor

I agree. Breaking is better

@p-ferreira p-ferreira added the 1.2.1 Potential push for v1.2.1 label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.2.1 Potential push for v1.2.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants