Skip to content

Conversation

@lachlan-00
Copy link
Member

@lachlan-00 lachlan-00 commented May 9, 2025

discussed here
#96 (reply in thread)

Essentially deprecate playCount for totalPlayCount and userPlayCount. If the servers don't use the same value for playCount might as well work towards removing it with 2 new items

@netlify
Copy link

netlify bot commented May 9, 2025

Deploy Preview for opensubsonic ready!

Name Link
🔨 Latest commit ed65b7c
🔍 Latest deploy log https://app.netlify.com/sites/opensubsonic/deploys/68212721e2712b00086d4266
😎 Deploy Preview https://deploy-preview-144--opensubsonic.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@epoupon
Copy link
Member

epoupon commented May 9, 2025

Note that there are scenarios where privacy is important: we don't want a user to be able to deduce anything about other users, such as listening habits.
Therefore, I wouldn't expect every OS server to necessarily implement this field, or if it does, it should be configurable

@paulijar
Copy link
Member

For a reader not having prior knowledge of these discussions, it's not at all obvious that fields totalCount and userCount have anything to do with the times the song has been played. So maybe they should be totalPlayCount and userPlayCount, even though these require a bit more typing?

@lachlan-00
Copy link
Member Author

Note that there are scenarios where privacy is important: we don't want a user to be able to deduce anything about other users, such as listening habits. Therefore, I wouldn't expect every OS server to necessarily implement this field, or if it does, it should be configurable

I would say that it's up to the server though to handle privacy but a good point. a count doesn't give you much information but it does give you information.

@lachlan-00
Copy link
Member Author

For a reader not having prior knowledge of these discussions, it's not at all obvious that fields totalCount and userCount have anything to do with the times the song has been played. So maybe they should be totalPlayCount and userPlayCount, even though these require a bit more typing?

Sure I'll change that now.

@lachlan-00 lachlan-00 changed the title separate playCount into totalCount and userCount separate playCount into totalPlayCount and userPlayCount May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants