Skip to content

Conversation

@harche
Copy link

@harche harche commented Dec 11, 2025

Test. please ignore.

k8s-ci-robot and others added 30 commits November 5, 2025 21:57
…ties-npe

Fix NPE in CEL schema wrappers of additionalProperties=true objects
Cleanup MinimumKubeletVersion test tag for unsupported kubelet versions
This considerably impacts the ability to merge PRs right now because it fails
in the merge-blocking pull-kubernetes-node-e2e-containerd. Attempts to fix
it seem to be incomplete and need further
discussion (kubernetes#135142),
so let's instead disable the test in the job.
…d-http-endpoints

kubeadm: support specifying HTTP endpoints for external etcd, allowing users to separate gRPC and HTTP traffic for etcd
feat(validation-gen): Improve ratcheting logic for nil vs. uncorrelated fields
…met/mini-cleanup

Revert "controller: duplicate utility method cleanup"
BenchmarkPerfSchedulingExperimental_benchmark_dra_experimental_2025-11-05T07:10:33Z.json
is ignored by perf-dash. It probably needs to be called
BenchmarkPerfScheduling_benchmark_*.
Some decisions about image pull credential verification can be applied
without reference to image pull credentials: e.g. if the policy is
NeverVerify, or if it is NeverVerifyPreloadedImages and the image is
preloaded, or if is NeverVerifyAllowListedImages and the image is
white-listed. In these cases, there is no need to look up credentials.
E2E node: temporarily disable flaky "pull from private registry"
…y volumes when the LocalStorageCapacityIsolationFSQuotaMonitoring feature-gate is enabled
Updated extended resource allocation scorer to calculate
allocatable and requested values for DRA-backed resources.
…-threads

pkg/controller: Improve goroutine management (part 2)
Introduce node declared features framework
…st-dynamic-interface

Promote/Enable WatchListClient feature for release 1.35
external-snapshot-metadata yaml files are on unusual place, so this script
would need some updates. Since the sidecar is not used in any e2e test,
skip the sidecar for now.
update-hostpath.sh must not remove volume group snapshot CRDs and e2e
script
k8s-release-robot and others added 8 commits December 8, 2025 09:37
If the the PCR that kubelet created gets deleted before it is issued, a
nil panic will be thrown while composing the error message.
…-panic

kubelet: Fix nil panic in podcertificatemanager
Merge resolution summary:
- go.mod/go.sum/vendor: Accept upstream for v1.35 dependencies
- CHANGELOG: Accept upstream version history
- build/cluster/hack: Accept upstream tooling changes
- test files: Accept upstream test updates
- pkg/kubelet: Preserve OpenShift carries for workload partitioning
  (sharedcpus, managed workloads, CPU resource clearing)
- pkg/features: Accept upstream feature gate version additions
- cmd/kube-controller-manager: Preserve OpenShift carries while
  adopting upstream refactoring (controller descriptors, daemon
  controller using NodeSelectorAware variant)
- staging/: Accept upstream etcd3 and apiserver changes

OpenShift carries preserved:
- Workload partitioning (sharedcpus, managed)
- NodeSelectorAwareDaemonSetsController
- InformerFactoryOverride
- OpenShiftContext in controller manager
- ServiceServingCertCA handling

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2025
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Dec 11, 2025
@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from jerpeter1 and tkashem December 11, 2025 18:30
@openshift-ci
Copy link

openshift-ci bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harche
Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

- Remove accidentally committed .cache/go-build/ files (8333 files)
- Add .cache/ to .gitignore to prevent future commits
- Fix go.mod: use proper pseudo-versions for openshift dependencies
  instead of branch names (release-4.22)
- Add replace directives pointing to jacobsee's forks with Go 1.25
  compatible versions of openshift libraries

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Dec 11, 2025
Signed-off-by: Harshal Patil <harpatil@redhat.com>
@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

Signed-off-by: Harshal Patil <harpatil@redhat.com>
@harche harche force-pushed the rebase-v1.35.0-rc.1 branch from 8cc84c1 to 135b1cd Compare December 12, 2025 01:39
@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

  - Add watch-termination and k8s-tests-ext to build targets
  - Set KUBE_STATIC_BINARIES to empty
  - Add setup_gomaxprocs function
  - Update build/pause/Dockerfile.Rhel to use Go 1.25 builder

Signed-off-by: Harshal Patil <harpatil@redhat.com>
@harche harche force-pushed the rebase-v1.35.0-rc.1 branch from d6a8c72 to 551dc9b Compare December 12, 2025 03:19
@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci
Copy link

openshift-ci bot commented Dec 12, 2025

@harche: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/k8s-e2e-conformance-aws 551dc9b link true /test k8s-e2e-conformance-aws
ci/prow/e2e-gcp 551dc9b link true /test e2e-gcp
ci/prow/e2e-aws-ovn-runc 551dc9b link true /test e2e-aws-ovn-runc
ci/prow/e2e-aws-crun-wasm 551dc9b link true /test e2e-aws-crun-wasm
ci/prow/e2e-aws-ovn-serial-1of2 551dc9b link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-aws-ovn-serial-2of2 551dc9b link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-aws-ovn-downgrade 551dc9b link true /test e2e-aws-ovn-downgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 551dc9b link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-techpreview 551dc9b link false /test e2e-aws-ovn-techpreview
ci/prow/k8s-e2e-gcp-serial 551dc9b link true /test k8s-e2e-gcp-serial
ci/prow/e2e-aws-ovn-cgroupsv2 551dc9b link true /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-crun 551dc9b link true /test e2e-aws-ovn-crun
ci/prow/e2e-aws-ovn-techpreview-serial-1of2 551dc9b link false /test e2e-aws-ovn-techpreview-serial-1of2
ci/prow/e2e-aws-ovn-hypershift 551dc9b link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-upgrade 551dc9b link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-azure-ovn-upgrade 551dc9b link true /test e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn-techpreview-serial-2of2 551dc9b link false /test e2e-aws-ovn-techpreview-serial-2of2
ci/prow/e2e-aws-ovn-fips 551dc9b link true /test e2e-aws-ovn-fips
ci/prow/k8s-e2e-gcp-ovn 551dc9b link true /test k8s-e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.