-
Notifications
You must be signed in to change notification settings - Fork 127
OCPBUGS-61515: UPSTREAM: 135372: Re-enable temporarily disabled SchedulerPreemption test #2524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-61515: UPSTREAM: 135372: Re-enable temporarily disabled SchedulerPreemption test #2524
Conversation
… priority pods first so all low priority pods can be preempted
|
@ingvagabund: This pull request references Jira Issue OCPBUGS-61515, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ingvagabund: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
passed in 1m55s. |
|
/retest-required |
… priority pods first so all low priority pods can be preempted
7936c45 to
cfa45c7
Compare
|
@ingvagabund: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
Based on https://www.kubernetes.dev/resources/release/#kubernetes-v135 the release is scheduled for Dec 17. The upstream fix is not that critical for the release so likely the fix will not get merged soon. |
|
Merged upstream |
|
/retest-required |
|
/verified by ci/prow/k8s-e2e-gcp-serial |
|
@ingvagabund: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/validate-backports |
|
@ingvagabund: the contents of this pull request could be automatically validated. The following commits are valid:
Comment |
|
lgtm should we squash the commits ? |
|
/label tide/merge-method-squash |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@ingvagabund: This pull request references Jira Issue OCPBUGS-61515, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@ingvagabund: This pull request references Jira Issue OCPBUGS-61515, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@ingvagabund: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
/cherry-pick release-4.21 |
|
@ingvagabund: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
581cfc7
into
openshift:master
|
@ingvagabund: Jira Issue Verification Checks: Jira Issue OCPBUGS-61515 Jira Issue OCPBUGS-61515 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ingvagabund: new pull request created: #2556 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Pulling kubernetes#135372 in