Skip to content

Conversation

@ingvagabund
Copy link
Member

Pulling kubernetes#135372 in

… priority pods first so all low priority pods can be preempted
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 20, 2025
@openshift-ci-robot
Copy link

@ingvagabund: This pull request references Jira Issue OCPBUGS-61515, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Pulling kubernetes#135372 in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@ingvagabund: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2025
@openshift-ci openshift-ci bot requested review from deads2k and tkashem November 20, 2025 16:43
@ingvagabund
Copy link
Member Author

Checking https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_kubernetes/2524/pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial/1991545177520476160:

Kubernetes e2e suite: [It] [sig-scheduling] SchedulerPreemption [Serial] validates various priority Pods preempt expectedly with the async preemption [Feature:SchedulerAsyncPreemption] [FeatureGate:SchedulerAsyncPreemption] [Beta]

passed in 1m55s.

@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund ingvagabund changed the title WIP: OCPBUGS-61515: UPSTREAM: <carry>: Re-enable temporarily disabled SchedulerPreemption test OCPBUGS-61515: UPSTREAM: <carry>: Re-enable temporarily disabled SchedulerPreemption test Dec 1, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2025
@ingvagabund ingvagabund changed the title OCPBUGS-61515: UPSTREAM: <carry>: Re-enable temporarily disabled SchedulerPreemption test OCPBUGS-61515: UPSTREAM: 135390: Re-enable temporarily disabled SchedulerPreemption test Dec 1, 2025
… priority pods first so all low priority pods can be preempted
@ingvagabund ingvagabund force-pushed the upstream-scheduler-preemption-fix branch from 7936c45 to cfa45c7 Compare December 1, 2025 10:34
@openshift-ci-robot
Copy link

@ingvagabund: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ingvagabund ingvagabund changed the title OCPBUGS-61515: UPSTREAM: 135390: Re-enable temporarily disabled SchedulerPreemption test OCPBUGS-61515: UPSTREAM: 135372: Re-enable temporarily disabled SchedulerPreemption test Dec 1, 2025
@ingvagabund
Copy link
Member Author

Based on https://www.kubernetes.dev/resources/release/#kubernetes-v135 the release is scheduled for Dec 17. The upstream fix is not that critical for the release so likely the fix will not get merged soon.

@ingvagabund
Copy link
Member Author

Merged upstream

@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund
Copy link
Member Author

/verified by ci/prow/k8s-e2e-gcp-serial

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 7, 2026
@openshift-ci-robot
Copy link

@ingvagabund: This PR has been marked as verified by ci/prow/k8s-e2e-gcp-serial.

Details

In response to this:

/verified by ci/prow/k8s-e2e-gcp-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ingvagabund
Copy link
Member Author

/validate-backports

@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Jan 7, 2026
@openshift-ci-robot
Copy link

@ingvagabund: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@p0lyn0mial
Copy link

lgtm

should we squash the commits ?

@ingvagabund
Copy link
Member Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 7, 2026
@p0lyn0mial
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2026
@ingvagabund
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@ingvagabund: This pull request references Jira Issue OCPBUGS-61515, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ingvagabund
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 7, 2026
@openshift-ci-robot
Copy link

@ingvagabund: This pull request references Jira Issue OCPBUGS-61515, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kasturinarra

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from kasturinarra January 7, 2026 11:50
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 76cb1db and 2 for PR HEAD cfa45c7 in total

@ingvagabund
Copy link
Member Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Jan 7, 2026

@ingvagabund: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview-serial-2of2 cfa45c7 link false /test e2e-aws-ovn-techpreview-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund
Copy link
Member Author

/cherry-pick release-4.21

@openshift-cherrypick-robot

@ingvagabund: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 581cfc7 into openshift:master Jan 8, 2026
23 of 24 checks passed
@openshift-ci-robot
Copy link

@ingvagabund: Jira Issue Verification Checks: Jira Issue OCPBUGS-61515
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-61515 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Pulling kubernetes#135372 in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@ingvagabund: new pull request created: #2556

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants