Skip to content

Conversation

@kevinrizza
Copy link
Member

Disable PSA enforcement in 4.21

Related to openshift/api#2623

See #6830 for reference

as PSA enforcement is not being enabled
in OpenShift 4.21
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 15, 2025
@openshift-ci-robot
Copy link

@kevinrizza: This pull request references Jira Issue OCPBUGS-61678, which is invalid:

  • expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Disable PSA enforcement in 4.21

Related to openshift/api#2623

See #6830 for reference

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Modified the default Pod Security Defaults enforcement policy in the KubeAPIServerConfig generation, changing the Enforce value from "restricted" to "privileged". No structural changes or additional behavioral modifications were introduced.

Changes

Cohort / File(s) Change Summary
Pod Security Defaults Configuration
control-plane-operator/controllers/hostedcontrolplane/v2/kas/config.go
Changed PodSecurityDefaults.Enforce default value from "restricted" to "privileged" in KubeAPIServerConfig generation

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • This is a single-file, value-based change with minimal scope
  • However, note that this modifies a security-related policy default that may have cluster-wide implications and should be validated for intent and impact
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link

@kevinrizza: This pull request references Jira Issue OCPBUGS-61678. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Disable PSA enforcement in 4.21

Related to openshift/api#2623

See #6830 for reference

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bryan-cox and sjenning December 15, 2025 14:33
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Dec 15, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kevinrizza
Once this PR has been reviewed and has the lgtm label, please assign devguyio for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants