-
Notifications
You must be signed in to change notification settings - Fork 219
[release-4.18] OCPBUGS-70315: Implement HTTPKeepAliveTimeout tuning option #1333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.18] OCPBUGS-70315: Implement HTTPKeepAliveTimeout tuning option #1333
Conversation
|
@alebedev87: This pull request references Jira Issue OCPBUGS-70315, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…option This commit updates `openshift/api` to include the new IngressController tuning option field: `HTTPKeepAliveTimeout`.
This commit implements `HTTPKeepAliveTimeout` tuning option of the IngressController API allowing customers to configure `timeout http-keep-alive`. In OCP versions prior to 4.16, this timeout was not respected (see haproxy/haproxy#2334). This implementation brings the ability to adjust the behavior to match pre-4.16 configurations.
Move `resolveIngressControllerAddress` and `canaryImageReference` functions from the idle connection test file to `util_test.go` because they are used in two places now. Add `checkRouteConnectivity` function to poll a route with GET requests.
e47e464 to
c126df7
Compare
|
Tested it with 4.18.0-0-2026-01-06-015149-test-ci-ln-ywhwtg2-latest |
|
/retest-required |
|
/label qe-approved |
|
@ShudiLi: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve This is a low-risk change. The openshift/api bump adds a new field that is nullable with no default value, the changes to the operator logic only take effect if the cluster-admin sets the new field to an explicit, non-nil value, and the rest of the changes are test refactoring and coverage for the new API field. /label backport-risk-approved |
|
@Miciah: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label backport-risk-assessed |
7ec6093
into
openshift:release-4.18
|
@alebedev87: Jira Issue Verification Checks: Jira Issue OCPBUGS-70315 Jira Issue OCPBUGS-70315 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.18.0-0.nightly-2026-01-06-195439 |
Manual cherry-pick of #1323.
This commit implements
HTTPKeepAliveTimeouttuning option of the IngressController API allowing customers to configuretimeout http-keep-alive.In OCP versions prior to 4.16, this timeout was not respected (see haproxy/haproxy#2334). This implementation brings the ability to adjust the behavior to match pre-4.16 configurations.
API PR: openshift/api#2638.