OCPBUGS-65476: Add openshift-ingress-operator ClusterRole to ClusterO… #1313

davidesalerno · 2025-11-28T15:39:12Z

…perator relatedObjects

This change adds the openshift-ingress-operator ClusterRole to the ClusterOperator relatedObjects

openshift-ci-robot · 2025-11-28T15:39:18Z

@davidesalerno: This pull request references Jira Issue OCPBUGS-65476, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

…perator relatedObjects

This change adds the openshift-ingress-operator ClusterRole to the ClusterOperator relatedObjects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

davidesalerno · 2025-12-01T11:13:36Z

/retest-required

grzpiotrowski · 2025-12-03T15:52:52Z

/assign

openshift-ci · 2025-12-04T13:52:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from grzpiotrowski. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Miciah · 2025-12-04T17:33:40Z

manifests/03-cluster-operator.yaml

+    - group: rbac.authorization.k8s.io
+      name: ingress-operator
+      resource: clusterrolebindings


The name here should match the name in manifests/01-cluster-role-binding.yaml:

Suggested change

- group: rbac.authorization.k8s.io

name: ingress-operator

resource: clusterrolebindings

- group: rbac.authorization.k8s.io

name: openshift-ingress-operator

resource: clusterrolebindings

cluster-ingress-operator/manifests/01-cluster-role-binding.yaml

Lines 2 to 5 in 35b0724

kind: ClusterRoleBinding

apiVersion: rbac.authorization.k8s.io/v1

metadata:

name: openshift-ingress-operator

Maybe you were looking at the rolebinding's name? We should probably include these too:

cluster-ingress-operator/manifests/01-role-binding.yaml

Lines 2 to 6 in 35b0724

kind: RoleBinding

apiVersion: rbac.authorization.k8s.io/v1

metadata:

name: ingress-operator

namespace: openshift-ingress-operator

cluster-ingress-operator/manifests/01-role-binding.yaml

Lines 23 to 27 in 35b0724

kind: RoleBinding

apiVersion: rbac.authorization.k8s.io/v1

metadata:

name: ingress-operator

namespace: openshift-config

...and then we might as well include the roles as well:

cluster-ingress-operator/manifests/01-role.yaml

Lines 2 to 6 in 35b0724

kind: Role

apiVersion: rbac.authorization.k8s.io/v1

metadata:

name: ingress-operator

namespace: openshift-ingress-operator

cluster-ingress-operator/manifests/01-role.yaml

Lines 43 to 47 in 35b0724

kind: Role

apiVersion: rbac.authorization.k8s.io/v1

metadata:

name: ingress-operator

namespace: openshift-config

@Miciah I updated the code accordingly and in particular:

fixed ClusterRole name

added the Roles and RolesBinding

Miciah · 2025-12-04T17:42:40Z

pkg/operator/controller/status/controller.go

As we discussed, it would also make sense to get the cluster ingress config and copy entries from Ingress.status.componentRoutes.relatedObjects to ClusterOperator.status.relatedObjects in Reconcile.

I updated the controller with the requested change.

openshift-ci · 2025-12-10T09:12:45Z

@davidesalerno: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test e2e-aws-operator

/test e2e-aws-ovn

/test e2e-aws-ovn-hypershift-conformance

/test e2e-aws-ovn-serial-1of2

/test e2e-aws-ovn-serial-2of2

/test e2e-aws-ovn-upgrade

/test e2e-azure-operator

/test e2e-gcp-operator

/test e2e-hypershift

/test hypershift-e2e-aks

/test images

/test okd-scos-images

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-aws-gatewayapi-conformance

/test e2e-aws-operator-techpreview

/test e2e-aws-ovn-single-node

/test e2e-aws-ovn-techpreview

/test e2e-aws-pre-release-ossm

/test e2e-azure-manual-oidc

/test e2e-azure-ovn

/test e2e-gcp-ovn

/test e2e-ibmcloud-operator

/test e2e-openstack-operator

/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator

pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn

pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-hypershift-conformance

pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-serial-1of2

pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-serial-2of2

pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-upgrade

pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-pre-release-ossm

pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-operator

pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-operator

pull-ci-openshift-cluster-ingress-operator-master-e2e-hypershift

pull-ci-openshift-cluster-ingress-operator-master-hypershift-e2e-aks

pull-ci-openshift-cluster-ingress-operator-master-images

pull-ci-openshift-cluster-ingress-operator-master-okd-scos-images

pull-ci-openshift-cluster-ingress-operator-master-unit

pull-ci-openshift-cluster-ingress-operator-master-verify

pull-ci-openshift-cluster-ingress-operator-master-verify-deps

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

davidesalerno · 2025-12-10T09:13:49Z

/test all

…perator relatedObjects Signed-off-by: Davide Salerno <dsalerno@redhat.com>

davidesalerno · 2025-12-11T14:11:34Z

/retest-required

openshift-ci · 2025-12-11T16:42:58Z

@davidesalerno: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-pre-release-ossm	`4303bbd`	link	false	`/test e2e-aws-pre-release-ossm`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

lihongan · 2025-12-12T12:28:26Z

/jira refresh

openshift-ci-robot · 2025-12-12T12:28:29Z

@lihongan: This pull request references Jira Issue OCPBUGS-65476, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

davidesalerno changed the title ~~OCPBUGS-65476: Add openshift-ingress-operator ClusterRole to ClusterO…~~ [WIP] OCPBUGS-65476: Add openshift-ingress-operator ClusterRole to ClusterO… Nov 28, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2025

openshift-ci bot requested review from frobware and knobunc November 28, 2025 15:39

davidesalerno force-pushed the ocpbugs65476 branch from 14bb378 to 21827f4 Compare November 28, 2025 16:15

davidesalerno force-pushed the ocpbugs65476 branch from 21827f4 to 103253e Compare December 2, 2025 09:11

davidesalerno changed the title ~~[WIP] OCPBUGS-65476: Add openshift-ingress-operator ClusterRole to ClusterO…~~ OCPBUGS-65476: Add openshift-ingress-operator ClusterRole to ClusterO… Dec 2, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2025

openshift-ci bot assigned grzpiotrowski Dec 3, 2025

davidesalerno force-pushed the ocpbugs65476 branch from 103253e to 35b0724 Compare December 4, 2025 13:46

Miciah reviewed Dec 4, 2025

View reviewed changes

davidesalerno changed the title ~~OCPBUGS-65476: Add openshift-ingress-operator ClusterRole to ClusterO…~~ [WIP] OCPBUGS-65476: Add openshift-ingress-operator ClusterRole to ClusterO… Dec 4, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2025

davidesalerno force-pushed the ocpbugs65476 branch 3 times, most recently from d00d433 to 1c93ae3 Compare December 5, 2025 14:04

davidesalerno marked this pull request as draft December 5, 2025 15:10

davidesalerno force-pushed the ocpbugs65476 branch from 1c93ae3 to 56d32cc Compare December 5, 2025 15:45

OCPBUGS-65476: Add openshift-ingress-operator ClusterRole to ClusterO…

4303bbd

…perator relatedObjects Signed-off-by: Davide Salerno <dsalerno@redhat.com>

davidesalerno force-pushed the ocpbugs65476 branch from 56d32cc to 4303bbd Compare December 10, 2025 15:38

davidesalerno changed the title ~~[WIP] OCPBUGS-65476: Add openshift-ingress-operator ClusterRole to ClusterO…~~ OCPBUGS-65476: Add openshift-ingress-operator ClusterRole to ClusterO… Dec 10, 2025

davidesalerno marked this pull request as ready for review December 10, 2025 17:32

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2025

openshift-ci bot requested review from rfredette and rikatz December 10, 2025 17:32

	kind: ClusterRoleBinding
	apiVersion: rbac.authorization.k8s.io/v1
	metadata:
	name: openshift-ingress-operator

	kind: RoleBinding
	apiVersion: rbac.authorization.k8s.io/v1
	metadata:
	name: ingress-operator
	namespace: openshift-ingress-operator

	kind: Role
	apiVersion: rbac.authorization.k8s.io/v1
	metadata:
	name: ingress-operator
	namespace: openshift-ingress-operator

OCPBUGS-65476: Add openshift-ingress-operator ClusterRole to ClusterO… #1313

Are you sure you want to change the base?

OCPBUGS-65476: Add openshift-ingress-operator ClusterRole to ClusterO… #1313

Conversation

davidesalerno commented Nov 28, 2025

Uh oh!

openshift-ci-robot commented Nov 28, 2025

Uh oh!

davidesalerno commented Dec 1, 2025

Uh oh!

grzpiotrowski commented Dec 3, 2025

Uh oh!

openshift-ci bot commented Dec 4, 2025

Uh oh!

Miciah Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Miciah Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Miciah Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

davidesalerno Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Miciah Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

davidesalerno Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Dec 10, 2025

Uh oh!

davidesalerno commented Dec 10, 2025

Uh oh!

davidesalerno commented Dec 11, 2025

Uh oh!

openshift-ci bot commented Dec 11, 2025

Uh oh!

lihongan commented Dec 12, 2025

Uh oh!

openshift-ci-robot commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants