Skip to content

Conversation

@ykmr1224
Copy link
Collaborator

Description

  • Remove Java11 review guidance as we no longer backport to 2.x

Related Issues

n/a

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Updated OpenSearch SQL guidelines to reflect the current Java requirement, removing references to Java 11 and standardizing on JDK 21.
    • Clarifies environment expectations for users and contributors following the guidelines, reducing confusion about supported Java versions.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

A Java 11 compatibility guideline was removed from the OpenSearch SQL review guidelines, leaving only the JDK 21 requirement documented.

Changes

Cohort / File(s) Summary
Review Guidelines Documentation
.rules/REVIEW_GUIDELINES.md
Removed Java 11 compatibility bullet point under OpenSearch SQL guidelines section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title succinctly describes the main change: removal of Java11 review guidance.
Description check ✅ Passed The description directly relates to the removal of Java11 review guidance, matching the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.


### OpenSearch SQL
- **JDK 21**: Required for development
- **Java 11 Compatibility**: Maintain when possible for OpenSearch 2.x
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as bug fix may need to backport, I suggest we remove it when we bump to 4.x

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider adding a description of "Only security fixes or only critical bug fixes can be backported to 2.x"?

@ykmr1224 ykmr1224 closed this Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants