[ENH] V1 -> V2 Migration - Flows (module) #1609
Conversation
Omswastik-11
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1609 +/- ##
==========================================
- Coverage 53.02% 51.57% -1.46%
==========================================
Files 36 47 +11
Lines 4326 4640 +314
==========================================
+ Hits 2294 2393 +99
- Misses 2032 2247 +215 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
very nice! I'll into this in more details but looks good overall.
There was a problem hiding this comment.
Can you review these tests ? I am not sure if these will work . It just validates Backward compatibility and High-level API delegates not like testing the real methods .
|
|
||
| return pd.DataFrame.from_dict(flows, orient="index") | ||
|
|
||
| def create(self, flow: OpenMLFlow) -> OpenMLFlow: |
There was a problem hiding this comment.
@geetu040 I was thinking for publishing the flows this method would work but as you said we need to look into it later so I didn't completed it yet . Is this method looks good to you ?
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Omswastik-11
force-pushed
the
flow-migration-stacked
branch
from
614411f to
36184e5
Compare
for more information, see https://pre-commit.ci
|
Hi @geetu040 !! Can you review the pre-commit failure It was due to merge conflicts more specifically for tasks . Should I change it on my branch ? |
4 participants
Fixes #1601
added a
Createmethod inFlowAPIfor publishing flow but not refactored with oldpublish. (Needs discussion on this)Added tests using
fake_methodsso that we can test without localV2server . I have tested theFlowsV2methods (getandexists) anddeleteandlistwere not implemented inV2server so I skipped them .