add support for remote usbmux; close connection at the end of fetch method #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for remote usbmux connections and ensures proper connection cleanup in the fetch method. The changes enable connecting to iOS devices through a remote usbmux server by introducing a new URL scheme http+usbmux+remote.
Key changes:
- Added
usbmux_addressparameter propagation through the connection chain to support remote usbmux servers - Implemented parsing and handling of the new
http+usbmux+remoteURL scheme - Added connection cleanup in the
fetchmethod's finally block to prevent resource leaks
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wda/usbmux/pyusbmux.py | Added usbmux_address parameter to make_http_connection method and USBMuxHTTPConnection class to support remote usbmux connections |
| wda/usbmux/init.py | Added URL parsing for http+usbmux+remote scheme and connection cleanup in the finally block of the fetch method |
| wda/init.py | Updated URL validation regex to accept the new http+usbmux+remote scheme |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.