Fix Histogram distribution text and E(x) formula #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakhimov
requested review from
AntoineRauzy,
MichelBatteux,
RobertoHerrero,
cfolleau,
emelendez-csn,
friedlhu and
mhibti
rakhimov
force-pushed
the
histogram
branch
4 times, most recently
from
45c86fb to
d4e164d
Compare
rakhimov
force-pushed
the
histogram
branch
5 times, most recently
from
7812584 to
dded0b7
Compare
rakhimov
force-pushed
the
histogram
branch
2 times, most recently
from
74b0f69 to
1e5a29a
Compare
Member
Author
|
The html result can be viewed from artifacts. |
The confusing E_i is swapped for w_i for weights.
The x is confusing in this context due to conventional use of x as the random variable (result of sampling).
The range is fixed to be right-exclusive as customary in other distribution sampling.
The two steps were confused in the sampling description. The steps are rearranged and clarified.
The =>Histogram formulas are fixed. The text looks very confusing and out-of-place, being a sign that these distributions should be provided separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Histogram distribution is reviewed to correct the formula and the text in general.
Confusing use of
xandEis avoided;instead, conventional
bfor boundaries andwfor weights are used in the formulas and text.Fixes #27